src/heap.h - Issue 11593007: Replace the use CharacterStreams in Heap::AllocateSymbolInternal and String::ComputeHash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.h

Issue 11593007: Replace the use CharacterStreams in Heap::AllocateSymbolInternal and String::ComputeHash (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap.h

diff --git a/src/heap.h b/src/heap.h

index 068c44e713f5569515606e2b582caee994ea17f1..f9a921e05d786c8b6b340c038ba636752a903138 100644

--- a/src/heap.h

+++ b/src/heap.h

@@ -764,8 +764,9 @@ class Heap {

Vector<const uc16> str,

uint32_t hash_field);

+ template<typename T>

MUST_USE_RESULT MaybeObject* AllocateInternalSymbol(

- unibrow::CharacterStream* buffer, int chars, uint32_t hash_field);

+ T t, int chars, uint32_t hash_field);

MUST_USE_RESULT MaybeObject* AllocateExternalSymbol(

Yang 2012/12/17 14:30:34 Let's remove this function header, while we are at

Vector<const char> str,

« no previous file with comments | « no previous file | src/heap.cc » ('j') | src/heap-inl.h » ('J')