Add a generic way for generator info to get passed to input to affect process...

Add a generic way for generator info to get passed to input to affect processing, this allows the generator to have optional keys with data that can extend input processing.
Split the path keys (for keeping things relative) into a base set and allow the generator to extend the list of keys.
Split the non configuration keys (to leave settings on targets) into a base set and allow the generator to extend the list of keys.
Add a flag for the generator to say if it handles variants or if input should deal with them, add a todo for the input handling.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=502

[Mark Mentovai, 2009-05-29 14:31:16]

Mostly LG, couple of comments.

http://codereview.chromium.org/115922/diff/1/5
File pylib/gyp/__init__.py (right):

http://codereview.chromium.org/115922/diff/1/5#newcode159
Line 159: 'geneartor_handles_variants', False),
80

http://codereview.chromium.org/115922/diff/1/5#newcode159
Line 159: 'geneartor_handles_variants', False),
1. geneartor is misspelled.  :)

2. The attributes as named in generators don't need generator_ prefixed.  It's
obvious that they're generator stuff because that's the module they're defined
in.

http://codereview.chromium.org/115922/diff/1/5#newcode161
Line 161: 'generator_additional_non_configuration_keys', []),
This lines up stupidly.  Nothing wrong with putting the getattr on a different
line from the associated key.

http://codereview.chromium.org/115922/diff/1/3
File pylib/gyp/generator/xcode.py (right):

http://codereview.chromium.org/115922/diff/1/3#newcode52
Line 52: 'mac_framework_dirs',
Isn't _dirs one of the magic suffixes?  We shouldn't need to list this
separately.

http://codereview.chromium.org/115922/diff/1/6
File pylib/gyp/input.py (right):

http://codereview.chromium.org/115922/diff/1/6#newcode1514
Line 1514: global non_configuration_keys
Blank line before

http://codereview.chromium.org/115922/diff/1/6#newcode1519
Line 1519: geneartor_handles_variants =
generator_input_info['geneartor_handles_variants']
80

[Mark Mentovai, 2009-05-29 14:54:59]

Add a hyphen to the comment in the msvs file too.  LGTM.

http://codereview.chromium.org/115922/diff/19/21
File pylib/gyp/generator/xcode.py (right):

http://codereview.chromium.org/115922/diff/19/21#newcode49
Line 49: # The xcode specific sections that hold paths
Xcode is spelled with a capital X (and a lowercase c).  Also on 55.  Also, put a
period at the end of this sentence (because you put one on the next comment.)

Xcode-specific ought to have a hyphen in it.

http://codereview.chromium.org/115922/diff/19/24
File pylib/gyp/input.py (right):

http://codereview.chromium.org/115922/diff/19/24#newcode45
Line 45: # with a list that can come from the generator to create
non_configuration_keys
Period at the end of your sentence.  (That'll bump you past 80, preemtpive
warning!)

http://codereview.chromium.org/115922/diff/19/24#newcode1510
Line 1510: # the generator specifc data.
generator hyphen specific.