Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1159203002: Add scripts to run, kill, debug, and set the command line for ChromePublic. (Closed)

Created:
5 years, 6 months ago by newt (away)
Modified:
5 years, 6 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add scripts to run, kill, debug, and set the command line for ChromePublic. These scripts are copied (with small modifications) from the equivalent scripts for ChromeShell. The scripts for ChromeShell will be deleted soon when ChromeShell goes away. BUG=484934 Committed: https://crrev.com/b777fe906e0846a1fcd6d01e3626768a1533e30b Cr-Commit-Position: refs/heads/master@{#331982}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
A + build/android/adb_chrome_public_command_line View 1 2 chunks +12 lines, -11 lines 0 comments Download
A build/android/adb_gdb_chrome_public View 1 chunk +16 lines, -0 lines 0 comments Download
A + build/android/adb_kill_chrome_public View 2 chunks +4 lines, -4 lines 0 comments Download
A + build/android/adb_run_chrome_public View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
newt (away)
PTAL
5 years, 6 months ago (2015-05-29 15:41:56 UTC) #2
jbudorick
lgtm https://codereview.chromium.org/1159203002/diff/1/build/android/adb_run_chrome_public File build/android/adb_run_chrome_public (right): https://codereview.chromium.org/1159203002/diff/1/build/android/adb_run_chrome_public#newcode11 build/android/adb_run_chrome_public:11: -n org.chromium.chrome/com.google.android.apps.chrome.Main \ Are we stuck with the ...
5 years, 6 months ago (2015-05-29 15:45:39 UTC) #3
newt (away)
On 2015/05/29 15:45:39, jbudorick wrote: > lgtm > > https://codereview.chromium.org/1159203002/diff/1/build/android/adb_run_chrome_public > File build/android/adb_run_chrome_public (right): > ...
5 years, 6 months ago (2015-05-29 15:48:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159203002/20001
5 years, 6 months ago (2015-05-29 15:52:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-05-29 16:05:19 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 16:07:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b777fe906e0846a1fcd6d01e3626768a1533e30b
Cr-Commit-Position: refs/heads/master@{#331982}

Powered by Google App Engine
This is Rietveld 408576698