chrome/test/data/instant_extended.html - Issue 11592004: InstantExtended: tests!

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/instant_extended.html

Issue 11592004: InstantExtended: tests! (Closed) Base URL: http://git.chromium.org/chromium/src.git@fixmyterms

Patch Set: Fix lint. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="instant_extended.js"></script>
	sreeram 2013/01/17 23:54:18 Just inline the script here, and get rid of the se Just inline the script here, and get rid of the separate file for the JS. The HTML parts of this file are never going to become much bigger, so it will just be a container for the script, which is fine (instant.html is written the same way). Perhaps you made the JS a separate file for editing (syntax highlighting)? At least vim does the right thing even when the JS is inlined. samarth 2013/01/18 00:06:45 Yeah, that's why, but inlined it. Show quoted text On 2013/01/17 23:54:18, sreeram wrote: > Just inline the script here, and get rid of the separate file for the JS. The > HTML parts of this file are never going to become much bigger, so it will just > be a container for the script, which is fine (instant.html is written the same > way). > > Perhaps you made the JS a separate file for editing (syntax highlighting)? At > least vim does the right thing even when the JS is inlined. Yeah, that's why, but inlined it.
	4 </head>

	5 <body>

	6 <h1>Instant</h1>

	7 </body>

	8 </html>

OLD	NEW