Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1159183003: Revert[6] of add asserts around results from requestLock (Closed)

Created:
5 years, 6 months ago by reed2
Modified:
5 years, 6 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert[6] of add asserts around results from requestLock This reverts commit 11e833d91b5ba2193ed593cb74900dddbec24b6f. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/db74f62c7a464c215b95f563ae4f7a991c4fd058

Patch Set 1 #

Patch Set 2 : don't leak the release-proc, even if there are no pixels #

Patch Set 3 : check for success in new tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -28 lines) Patch
M include/core/SkBitmap.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M include/core/SkPixelRef.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/core/SkBitmap.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/core/SkPixelRef.cpp View 5 chunks +42 lines, -26 lines 0 comments Download
M tests/PixelRefTest.cpp View 1 2 2 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159183003/20001
5 years, 6 months ago (2015-05-30 20:06:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159183003/40001
5 years, 6 months ago (2015-05-30 20:28:00 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-05-30 20:41:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/db74f62c7a464c215b95f563ae4f7a991c4fd058

Powered by Google App Engine
This is Rietveld 408576698