Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Unified Diff: ui/views/controls/webview/webview_interactive_uitest.cc

Issue 1159183002: Improve process crash handling in RenderViewHost & mock RenderProcessHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile problem in webview_interactive_uitest.cc Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/test_renderer_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/webview/webview_interactive_uitest.cc
diff --git a/ui/views/controls/webview/webview_interactive_uitest.cc b/ui/views/controls/webview/webview_interactive_uitest.cc
index d8598184e176d356a2fdc8551b6af5b57eb19fba..e13b24ea1c0f120f244cd9c4342b1ba9c474610d 100644
--- a/ui/views/controls/webview/webview_interactive_uitest.cc
+++ b/ui/views/controls/webview/webview_interactive_uitest.cc
@@ -7,6 +7,7 @@
#include "base/command_line.h"
#include "base/memory/scoped_ptr.h"
#include "content/public/browser/web_contents.h"
+#include "content/public/test/mock_render_process_host.h"
#include "content/public/test/test_browser_context.h"
#include "content/public/test/test_browser_thread.h"
#include "content/public/test/test_renderer_host.h"
@@ -89,6 +90,7 @@ TEST_F(WebViewInteractiveUiTest, TextInputClientIsUpToDate) {
// Case 1: Creates a new WebContents.
content::WebContents* web_contents1 = webview->GetWebContents();
+ web_contents1->GetRenderViewHost()->GetProcess()->Init();
content::RenderViewHostTester::For(web_contents1->GetRenderViewHost())
->CreateRenderView(base::string16(), MSG_ROUTING_NONE, MSG_ROUTING_NONE,
-1, false);
@@ -101,6 +103,7 @@ TEST_F(WebViewInteractiveUiTest, TextInputClientIsUpToDate) {
scoped_ptr<content::WebContents> web_contents2(
content::WebContentsTester::CreateTestWebContents(browser_context(),
nullptr));
+ web_contents2->GetRenderViewHost()->GetProcess()->Init();
content::RenderViewHostTester::For(web_contents2->GetRenderViewHost())
->CreateRenderView(base::string16(), MSG_ROUTING_NONE, MSG_ROUTING_NONE,
-1, false);
« no previous file with comments | « content/public/test/test_renderer_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698