Improve process crash handling in RenderViewHost & mock RenderProcessHost.

content/public/test/mock_render_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/mock_render_process_host.h"
 
 #include <algorithm>
 #include <utility>
 #include <vector>
 
@@ skipping 15 matching lines @@
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_widget_host_iterator.h"
 #include "content/public/browser/storage_partition.h"
 
 namespace content {
 
 MockRenderProcessHost::MockRenderProcessHost(BrowserContext* browser_context)
     : bad_msg_count_(0),
       factory_(NULL),
       id_(ChildProcessHostImpl::GenerateChildProcessUniqueId()),
+      has_connection_(false),
       browser_context_(browser_context),
       prev_routing_id_(0),
       fast_shutdown_started_(false),
       deletion_callback_called_(false),
       is_isolated_guest_(false) {
   // Child process security operations can't be unit tested unless we add
   // ourselves as an existing child process.
   ChildProcessSecurityPolicyImpl::GetInstance()->Add(GetID());
 
   RenderProcessHostImpl::RegisterHost(GetID(), this);
 }
 
 MockRenderProcessHost::~MockRenderProcessHost() {
   ChildProcessSecurityPolicyImpl::GetInstance()->Remove(GetID());
   if (factory_)
     factory_->Remove(this);
 
   // In unit tests, Cleanup() might not have been called.
   if (!deletion_callback_called_) {
     FOR_EACH_OBSERVER(RenderProcessHostObserver,
                       observers_,
                       RenderProcessHostDestroyed(this));
     RenderProcessHostImpl::UnregisterHost(GetID());
   }
 }
 
 void MockRenderProcessHost::SimulateCrash() {
+  has_connection_ = false;
   RenderProcessHost::RendererClosedDetails details(
       base::TERMINATION_STATUS_PROCESS_CRASHED, 0);
   NotificationService::current()->Notify(
       NOTIFICATION_RENDERER_PROCESS_CLOSED, Source<RenderProcessHost>(this),
       Details<RenderProcessHost::RendererClosedDetails>(&details));
 
+  FOR_EACH_OBSERVER(
+      RenderProcessHostObserver, observers_,
+      RenderProcessExited(this, details.status, details.exit_code));
+
   // Send every routing ID a FrameHostMsg_RenderProcessGone message. To ensure a
   // predictable order for unittests which may assert against the order, we sort
   // the listeners by descending routing ID, instead of using the arbitrary
   // hash-map order like RenderProcessHostImpl.
   std::vector<std::pair<int32, IPC::Listener*>> sorted_listeners_;
   IDMap<IPC::Listener>::iterator iter(&listeners_);
   while (!iter.IsAtEnd()) {
     sorted_listeners_.push_back(
         std::make_pair(iter.GetCurrentKey(), iter.GetCurrentValue()));
     iter.Advance();
   }
   std::sort(sorted_listeners_.rbegin(), sorted_listeners_.rend());
 
   for (auto& entry_pair : sorted_listeners_) {
     entry_pair.second->OnMessageReceived(FrameHostMsg_RenderProcessGone(
         entry_pair.first, static_cast<int>(details.status), details.exit_code));
   }
 }
 
 void MockRenderProcessHost::EnableSendQueue() {
 }
 
 bool MockRenderProcessHost::Init() {
+  has_connection_ = true;
   return true;
 }
 
 int MockRenderProcessHost::GetNextRoutingID() {
   return ++prev_routing_id_;
 }
 
 void MockRenderProcessHost::AddRoute(
     int32 routing_id,
     IPC::Listener* listener) {
@@ skipping 68 matching lines @@
   sink_.OnMessageReceived(*msg);
   delete msg;
   return true;
 }
 
 int MockRenderProcessHost::GetID() const {
   return id_;
 }
 
 bool MockRenderProcessHost::HasConnection() const {
-  return true;
+  return has_connection_;
 }
 
 void MockRenderProcessHost::SetIgnoreInputEvents(bool ignore_input_events) {
 }
 
 bool MockRenderProcessHost::IgnoreInputEvents() const {
   return false;
 }
 
 void MockRenderProcessHost::Cleanup() {
@@ skipping 147 matching lines @@
   for (ScopedVector<MockRenderProcessHost>::iterator it = processes_.begin();
        it != processes_.end(); ++it) {
     if (*it == host) {
       processes_.weak_erase(it);
       break;
     }
   }
 }
 
 }  // content