Issue 1159173004: Non racy tests for memlock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1159173004: Non racy tests for memlock. (Closed)

Created:
5 years, 6 months ago by iannucci

Modified:
5 years, 6 months ago

Reviewers:
dnj, Vadim Sh., M-A Ruel

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/infra/infra.git@master

Target Ref:
refs/heads/master

Project:
infra

Visibility:
Public.

Non racy tests for memlock. Bonus, no more time.Sleep, and the tests are 100% faster (e.g. they take 0.04s instead of 0.08s :D ) R=dnj@chromium.org, maruel@chromium.org, vadimsh@chromium.org BUG=496436 Committed: https://chromium.googlesource.com/infra/infra/+/9027955f6a3dd20cac868c4727c328690fe92550

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -32 lines)			Patch
M	go/src/infra/gae/libs/memlock/memlock.go	View	3 chunks	+8 lines, -7 lines	0 comments	Download
A	go/src/infra/gae/libs/memlock/memlock.infra_testing	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	go/src/infra/gae/libs/memlock/memlock_test.go	View	4 chunks	+51 lines, -25 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159173004/1

5 years, 6 months ago (2015-06-04 01:46:37 UTC) #4

commit-bot: I haz the power

5 years, 6 months ago (2015-06-04 01:49:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/9027955f6a3dd20cac868c4727c32...