Source/devtools/front_end/security/module.json - Issue 1159163005: Add a minimal Security panel to DevTools (behind a hidden experiment).

Side by Side Diff: Source/devtools/front_end/security/module.json

Issue 1159163005: Add a minimal Security panel to DevTools (behind a hidden experiment). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/devtools/front_end/security/SecurityPanel.js ('K') | « Source/devtools/front_end/security/SecurityPanel.js ('k') | Source/devtools/front_end/security/securityPanel.css » ('j') | Source/devtools/front_end/security/securityPanel.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "extensions": [

	3 {

	4 "type": "@WebInspector.PanelFactory",

	5 "name": "security",

	6 "title": "Security",

	7 "order": 7,

	8 "className": "WebInspector.SecurityPanelFactory"

	9 }

	10 ],

	11 "dependencies": [],
	dgozman 2015/06/03 10:12:35 You probably have to depend on platform, host, and You probably have to depend on platform, host, and sdk. lgarron 2015/06/11 22:54:47 What are each of these? The other panels don't hav Show quoted text On 2015/06/03 at 10:12:35, dgozman wrote: > You probably have to depend on platform, host, and sdk. What are each of these? The other panels don't have these in their `module.json` files. How do I learn how dependencies work? dgozman 2015/06/12 06:20:22 If you use something (class, function) from a file Show quoted text On 2015/06/11 22:54:47, lgarron wrote: > On 2015/06/03 at 10:12:35, dgozman wrote: > > You probably have to depend on platform, host, and sdk. > > What are each of these? The other panels don't have these in their `module.json` > files. > How do I learn how dependencies work? If you use something (class, function) from a file of another module, you have to declare the dependency here. Most of the DOM helpers are in platform module. Targets and models are in sdk. Not sure about host, maybe you won't need it directly. Do not include unless compiler complains. lgarron 2015/06/12 19:56:01 Makes sense. I didn't know anything about the comp Show quoted text On 2015/06/12 at 06:20:22, dgozman wrote: > On 2015/06/11 22:54:47, lgarron wrote: > > On 2015/06/03 at 10:12:35, dgozman wrote: > > > You probably have to depend on platform, host, and sdk. > > > > What are each of these? The other panels don't have these in their `module.json` > > files. > > How do I learn how dependencies work? > > If you use something (class, function) from a file of another module, you have to declare the dependency here. > Most of the DOM helpers are in platform module. Targets and models are in sdk. Not sure about host, maybe you won't need it directly. Do not include unless compiler complains. Makes sense. I didn't know anything about the compiler, but I'm assuming `git cl presubmit --upload` gives the relevant output. I found that the compiler is just as happy without "platform" and "host", but needs "sdk". It also seems to need "ui". So, right now I have: "dependencies": ["platform", "ui", "sdk"] Is there something else I should be using in "ui"? dgozman 2015/06/15 16:58:41 Yep. Show quoted text > Makes sense. I didn't know anything about the compiler, but I'm assuming `git cl > presubmit --upload` gives the relevant output. Yep. Show quoted text > I found that the compiler is just as happy without "platform" and "host", but > needs "sdk". It also seems to need "ui". So, right now I have: > "dependencies": ["platform", "ui", "sdk"] Dependencies are transitive (just like includes), so platform is indirectly included in compilation through sdk/ui. Show quoted text > Is there something else I should be using in "ui"? Not sure what you mean. Use what you need.
	12 "experiment": "securityPanel",

	13 "scripts": [

	14 "SecurityPanel.js"

	15 ],

	16 "resources": [

	17 "securityPanel.css"

	18 ]

	19 }

OLD	NEW