Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1159153003: Sample allocation throughput in all idle notifications. (Closed)

Created:
5 years, 6 months ago by ulan
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Sample allocation throughput in all idle notifications. This removes special handling of long idle notifications. BUG= Committed: https://crrev.com/5aaceefd9a84327ce6afeaea16557449bf83ce57 Cr-Commit-Position: refs/heads/master@{#28833}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove more #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -34 lines) Patch
M src/heap/gc-tracer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M src/heap/heap.cc View 1 2 7 chunks +7 lines, -27 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
ulan
PTAL. In the next CL I will remove long_idle_notification handling when transitioning to reduce memory ...
5 years, 6 months ago (2015-06-03 10:53:25 UTC) #2
Hannes Payer (out of office)
lgtm, please add a more descriptive title and description to the cl
5 years, 6 months ago (2015-06-03 11:29:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159153003/1
5 years, 6 months ago (2015-06-03 13:08:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/999)
5 years, 6 months ago (2015-06-03 13:10:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159153003/20001
5 years, 6 months ago (2015-06-08 08:15:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/6391)
5 years, 6 months ago (2015-06-08 09:12:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159153003/40001
5 years, 6 months ago (2015-06-08 10:06:24 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-08 11:24:03 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 11:24:16 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5aaceefd9a84327ce6afeaea16557449bf83ce57
Cr-Commit-Position: refs/heads/master@{#28833}

Powered by Google App Engine
This is Rietveld 408576698