Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2144)

Unified Diff: content/public/test/browser_test_utils.h

Issue 1159143008: Fix wrong initialization of renderer_initiated_creation parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adding check Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/browser_test_utils.h
diff --git a/content/public/test/browser_test_utils.h b/content/public/test/browser_test_utils.h
index bcc424fe289b905f19049d4e425572d041c48322..7c7183d50b800d287ea2f9d2e24e6732bb0180d0 100644
--- a/content/public/test/browser_test_utils.h
+++ b/content/public/test/browser_test_utils.h
@@ -380,7 +380,7 @@ class DOMMessageQueue : public NotificationObserver {
class WebContentsAddedObserver {
public:
WebContentsAddedObserver();
- ~WebContentsAddedObserver();
+ virtual ~WebContentsAddedObserver();
// Will run a message loop to wait for the new window if it hasn't been
// created since the constructor
@@ -389,11 +389,12 @@ class WebContentsAddedObserver {
// Will tell whether RenderViewCreated Callback has invoked
bool RenderViewCreatedCalled();
+ protected:
+ virtual void WebContentsCreated(WebContents* web_contents);
+
private:
class RenderViewCreatedObserver;
- void WebContentsCreated(WebContents* web_contents);
-
// Callback to WebContentCreated(). Cached so that we can unregister it.
base::Callback<void(WebContents*)> web_contents_created_callback_;

Powered by Google App Engine
This is Rietveld 408576698