Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: content/browser/frame_host/frame_tree_unittest.cc

Issue 1159143008: Fix wrong initialization of renderer_initiated_creation parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing mmenke@'s comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/frame_tree_unittest.cc
diff --git a/content/browser/frame_host/frame_tree_unittest.cc b/content/browser/frame_host/frame_tree_unittest.cc
index d74d97c0a40ba1bf1d493cb72b6410cfe09e0a83..fa018674e368d674a1fe19e54e81b38abccc308c 100644
--- a/content/browser/frame_host/frame_tree_unittest.cc
+++ b/content/browser/frame_host/frame_tree_unittest.cc
@@ -229,9 +229,12 @@ TEST_F(FrameTreeTest, DISABLED_Shape) {
// Ensure frames can be found by frame_tree_node_id, routing ID, or name.
TEST_F(FrameTreeTest, FindFrames) {
+ main_test_rfh()->InitializeRenderFrameIfNeeded();
+
// Add a few child frames to the main frame.
FrameTree* frame_tree = contents()->GetFrameTree();
FrameTreeNode* root = frame_tree->root();
+
main_test_rfh()->OnCreateChildFrame(22, blink::WebTreeScopeType::Document,
"child0", blink::WebSandboxFlags::None);
main_test_rfh()->OnCreateChildFrame(23, blink::WebTreeScopeType::Document,
@@ -278,6 +281,8 @@ TEST_F(FrameTreeTest, FindFrames) {
// Check that PreviousSibling() is retrieved correctly.
TEST_F(FrameTreeTest, PreviousSibling) {
+ main_test_rfh()->InitializeRenderFrameIfNeeded();
+
// Add a few child frames to the main frame.
FrameTree* frame_tree = contents()->GetFrameTree();
FrameTreeNode* root = frame_tree->root();
@@ -387,6 +392,8 @@ TEST_F(FrameTreeTest, FailAddFrameWithWrongProcessId) {
// Ensure that frames removed while a process has crashed are not preserved in
// the global map of id->frame.
TEST_F(FrameTreeTest, ProcessCrashClearsGlobalMap) {
+ main_test_rfh()->InitializeRenderFrameIfNeeded();
+
// Add a couple child frames to the main frame.
FrameTreeNode* root = contents()->GetFrameTree()->root();
« no previous file with comments | « chrome/browser/net/net_error_tab_helper_unittest.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698