chrome/browser/background/background_contents.cc - Issue 1159143008: Fix wrong initialization of renderer_initiated_creation parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_contents.cc

Issue 1159143008: Fix wrong initialization of renderer_initiated_creation parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing mmenke@'s comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/background/background_contents.cc

diff --git a/chrome/browser/background/background_contents.cc b/chrome/browser/background/background_contents.cc

index 258faf3c4eb6ff3bd28d3ac2a147f9c6c4e4bf75..6b02c78a44190ef227f0d969f3f2cacd2514b52f 100644

--- a/chrome/browser/background/background_contents.cc

+++ b/chrome/browser/background/background_contents.cc

@@ -44,7 +44,7 @@ BackgroundContents::BackgroundContents(

WebContents::CreateParams create_params(profile_, site_instance);

create_params.routing_id = routing_id;

create_params.main_frame_routing_id = main_frame_routing_id;

- create_params.renderer_initiated_creation = true;

+ create_params.renderer_initiated_creation = routing_id != MSG_ROUTING_NONE;

if (session_storage_namespace) {

content::SessionStorageNamespaceMap session_storage_namespace_map;

session_storage_namespace_map.insert(

« no previous file with comments | « no previous file | chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc » ('j') | no next file with comments »