Fix wrong initialization of renderer_initiated_creation parameter.

content/browser/frame_host/render_frame_host_manager_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
 #include "base/memory/ref_counted.h"
 #include "base/path_service.h"
@@ skipping 1788 matching lines @@
   RenderFrameHostDestructionObserver rfh_observer(root->current_frame_host());
   NavigateToURL(shell(), cross_site_url);
   rfh_observer.Wait();
 
   EXPECT_NE(orig_site_instance_id,
             root->current_frame_host()->GetSiteInstance()->GetId());
   EXPECT_FALSE(RenderFrameHost::FromID(initial_process_id, initial_rfh_id));
   EXPECT_FALSE(RenderViewHost::FromID(initial_process_id, initial_rvh_id));
 }
 
+// This class ensures that all RenderFrameCreated callbacks have processes with
+// IPC channels.
+class RenderFrameCreatedHasConnectionObserver : public WebContentsObserver {
+ public:
+  explicit RenderFrameCreatedHasConnectionObserver(WebContents* web_contents)
+      : WebContentsObserver(web_contents) {}
+  ~RenderFrameCreatedHasConnectionObserver() override {}
+
+ private:
+  // WebContentsObserver implementation:
+  void RenderFrameCreated(RenderFrameHost* render_frame_host) override {
+    EXPECT_TRUE(render_frame_host->GetProcess()->HasConnection());
+    EXPECT_TRUE(static_cast<RenderFrameHostImpl*>(render_frame_host)
+                    ->IsRenderFrameLive());

[ncarter (slow), 2015/06/04 18:20:46]

Rather than opening up WebContentsObserver so that we can write this assert,
would it be possible to move these asserts into
https://code.google.com/p/chromium/codesearch#chromium/src/content/test/web_c...
?

That would have the effect of adding them to all tests everywhere, including
unit tests. The downside is that you may discover some failures that need to be
patched up (though hopefully not too many; I think nasko has been treading this
water already).

+  }
+};
+
+// This class installs the RenderFrameCreatedHasConnectionObserver when the
+// new WebContents is created.
+class InstallRFCObserver : public WebContentsAddedObserver {
+ public:
+  InstallRFCObserver() : rfco_(nullptr) {}
+  ~InstallRFCObserver() override { delete rfco_; }
+
+ private:
+  void WebContentsCreated(WebContents* web_contents) override {
+    rfco_ = new RenderFrameCreatedHasConnectionObserver(web_contents);
+
+    WebContentsAddedObserver::WebContentsCreated(web_contents);
+  }
+
+  RenderFrameCreatedHasConnectionObserver* rfco_;
+};
+
+// Following a cross-site link with rel=noreferrer and target=_blank should
+// fire RenderFrameCreated only after the process is created.
+IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
+                       RenderFrameCreatedWithRelNoreferrerAndTargetBlank) {
+  StartServer();
+
+  // Load a page with links that open in a new window.
+  std::string replacement_path;
+  ASSERT_TRUE(GetFilePathWithHostAndPortReplacement(
+      "files/click-noreferrer-links.html",
+      foo_host_port_,
+      &replacement_path));
+  NavigateToURL(shell(), test_server()->GetURL(replacement_path));
+
+  // Test clicking a rel=noreferrer + target=blank link.
+  InstallRFCObserver web_contents_observer;
+  bool success = false;
+  EXPECT_TRUE(ExecuteScriptAndExtractBool(
+      shell()->web_contents(),
+      "window.domAutomationController.send(clickNoRefTargetBlankLink());",
+      &success));
+  EXPECT_TRUE(success);
+
+  // Wait for the WebContents to be created.
+  WebContentsImpl* new_web_contents =
+      static_cast<WebContentsImpl*>(web_contents_observer.GetWebContents());
+
+  // Wait for the cross-site transition in the new tab to finish.
+  WaitForLoadStop(new_web_contents);
+  EXPECT_EQ("/files/title2.html", new_web_contents->GetVisibleURL().path());
+}
+
 }  // namespace content