Fix wrong initialization of renderer_initiated_creation parameter.

chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/captive_portal/captive_portal_tab_helper.h"
 
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/captive_portal/captive_portal_service.h"
 #include "chrome/browser/captive_portal/captive_portal_tab_reloader.h"
@@ skipping 58 matching lines @@
       : tab_helper_(NULL),
         mock_reloader_(new testing::StrictMock<MockCaptivePortalTabReloader>) {
     tab_helper_.SetTabReloaderForTest(mock_reloader_);
   }
   ~CaptivePortalTabHelperTest() override {}
 
   void SetUp() override {
     ChromeRenderViewHostTestHarness::SetUp();
     web_contents1_.reset(CreateTestWebContents());
     web_contents2_.reset(CreateTestWebContents());
+    content::RenderFrameHostTester::For(main_render_frame1())
+        ->InitializeRenderFrameIfNeeded();
+    content::RenderFrameHostTester::For(main_render_frame2())
+        ->InitializeRenderFrameIfNeeded();

[mmenke, 2015/06/08 16:09:49]

Need to include the header for RenderFrameHostTester.

[mmenke, 2015/06/08 16:09:50]

Why are these needed?  What do they do?  I assume they aren't needed for all
TestWebContents, or this could just be part of CreateTestWebContents().

[lfg, 2015/06/08 17:04:01]

The header is already included because of the inheritance (it is defined in
test_renderer_host.h, which defines RenderViewHostTestHarness, which is the
superclass of ChromeRenderViewHostTestHarness).

I can include it explicitly if you prefer.

[lfg, 2015/06/08 17:04:01]

There are a few reasons for this, the main one is that we're adding extra
asserts to make the code more robust and initializing the RenderFrame is
something that needs to be done before we can use it. In a real-world scenario,
creating a WebContents doesn't initialize the RenderFrame. We can't expect to
receive IPCs without initializing it first (i.e. DidStartProvisionalLoadForFrame
comes from an IPC from a renderer).

[mmenke, 2015/06/08 17:15:06]

Could you add some sort of comment here?  It's neither obvious from this method
or the RenderFrameHostTester header what's going on.  Just something like
"WebContents create no main frame on cosntruction, and these tests expect one to
exist."

Same goes for the browser/net file.  Alternatively, could mention something
about it in web_contents_tester.h

[mmenke, 2015/06/08 17:15:06]

I'd prefer it be included explicitly - same goes for the browser/net file.

[lfg, 2015/06/08 18:25:51]

Done.

[lfg, 2015/06/08 18:25:51]

Done.

   }
 
   void TearDown() override {
     web_contents2_.reset(NULL);
     web_contents1_.reset(NULL);
     ChromeRenderViewHostTestHarness::TearDown();
   }
 
   // Simulates a successful load of |url|.
   void SimulateSuccess(const GURL& url,
@@ skipping 550 matching lines @@
   EXPECT_FALSE(tab_helper().IsLoginTab());
 
   ObservePortalResult(captive_portal::RESULT_BEHIND_CAPTIVE_PORTAL,
                       captive_portal::RESULT_NO_RESPONSE);
   EXPECT_FALSE(tab_helper().IsLoginTab());
 
   ObservePortalResult(captive_portal::RESULT_NO_RESPONSE,
                       captive_portal::RESULT_INTERNET_CONNECTED);
   EXPECT_FALSE(tab_helper().IsLoginTab());
 }