Fix wrong initialization of renderer_initiated_creation parameter.

content/test/web_contents_observer_sanity_checker.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/test/web_contents_observer_sanity_checker.h"
 
 #include "base/strings/stringprintf.h"
+#include "content/browser/frame_host/render_frame_host_impl.h"
 #include "content/common/frame_messages.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
 
 namespace content {
 
 namespace {
@@ skipping 17 matching lines @@
   std::pair<int, int> routing_pair =
       std::make_pair(render_frame_host->GetProcess()->GetID(),
                      render_frame_host->GetRoutingID());
   bool frame_exists = !live_routes_.insert(routing_pair).second;
   deleted_routes_.erase(routing_pair);
 
   if (frame_exists) {
     CHECK(false) << "RenderFrameCreated called more than once for routing pair:"
                  << Format(render_frame_host);
   }
+
+  CHECK(render_frame_host->GetProcess()->HasConnection());

[ncarter (slow), 2015/06/05 21:47:50]

<< "RenderFrameCreated was called for a RenderFrameHost whose render process is
not currently live, so there's no way for the RenderFrame to have been created."

Or something like that. These CHECKS are lurking pretty far from the code that
triggers them, so we should do our best to orient the unlucky developer who runs
afoul of them.

[lfg, 2015/06/05 22:07:07]

Done.

+  CHECK(static_cast<RenderFrameHostImpl*>(render_frame_host)
+            ->IsRenderFrameLive());

[ncarter (slow), 2015/06/05 21:47:50]

<< "RenderFrameCreated called on for a RenderFrameHost that thinks it is not
alive. RenderFrames should always be alive at the moment of creation."

... or something similar.

[lfg, 2015/06/05 22:07:07]

Done.

 }
 
 void WebContentsObserverSanityChecker::RenderFrameDeleted(
     RenderFrameHost* render_frame_host) {
   CHECK(!web_contents_destroyed_);
   std::pair<int, int> routing_pair =
       std::make_pair(render_frame_host->GetProcess()->GetID(),
                      render_frame_host->GetRoutingID());
   bool was_live = !!live_routes_.erase(routing_pair);
   bool was_dead_already = !deleted_routes_.insert(routing_pair).second;
@@ skipping 193 matching lines @@
 
 std::string WebContentsObserverSanityChecker::Format(
     RenderFrameHost* render_frame_host) {
   return base::StringPrintf(
       "(%d, %d -> %s)", render_frame_host->GetProcess()->GetID(),
       render_frame_host->GetRoutingID(),
       render_frame_host->GetSiteInstance()->GetSiteURL().spec().c_str());
 }
 
 }  // namespace content