chrome/browser/renderer_context_menu/render_view_context_menu.cc - Issue 1159143002: Add a basic functionality to the force-saving menu item.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 1159143002: Add a basic functionality to the force-saving menu item. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added stub methods. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | components/autofill/content/common/autofill_messages.h » ('j') | components/password_manager/core/browser/password_manager_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc

diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

index 2c54f9709bb2615ed44fe955b473458a6246361e..8af019df57b9f36a23c1a2a2b10f6461053833fb 100644

--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc

+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

@@ -33,6 +33,7 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"

#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"

+#include "chrome/browser/password_manager/chrome_password_manager_client.h"

#include "chrome/browser/plugins/chrome_plugin_service_filter.h"

#include "chrome/browser/prefs/incognito_mode_prefs.h"

#include "chrome/browser/profiles/profile.h"

@@ -1800,7 +1801,8 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {

}

case IDC_CONTENT_CONTEXT_FORCESAVEPASSWORD:

- // TODO(msramek): Force-save the password.

+ ChromePasswordManagerClient::FromWebContents(source_web_contents_)->

+ ForceSavePassword();

break;

default: