Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1159143002: Add a basic functionality to the force-saving menu item. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 1fd7d7744a2551283713f769d40c811dfbfa42b8..3375a3e8b5ef50bb9c11a72a8971135f9ca9f3a4 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -359,6 +359,16 @@ void PasswordManager::OnPasswordFormSubmitted(
pending_login_managers_.clear();
}
+void PasswordManager::OnPasswordFormForceSaveRequested(
+ password_manager::PasswordManagerDriver* driver,
+ const PasswordForm& password_form) {
+ // TODO(msramek): This is just a sketch. We will need to show a custom bubble,
+ // mark the form as force saved, and recreate the pending login managers,
+ // because the password store might have changed.
+ ProvisionallySavePassword(password_form);
+ AskUserOrSavePassword();
+}
+
void PasswordManager::OnPasswordFormsParsed(
password_manager::PasswordManagerDriver* driver,
const std::vector<PasswordForm>& forms) {

Powered by Google App Engine
This is Rietveld 408576698