Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1159113009: Revert of Make WebURLLoader capable of retaining received buffers. (Closed)

Created:
5 years, 6 months ago by M-A Ruel
Modified:
5 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make WebURLLoader capable of retaining received buffers. (patchset #19 id:560001 of https://codereview.chromium.org/1103813002/) Reason for revert: It broke Win x64 GN (dbg) http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/2674/steps/compile/logs/stdio e:\b\build\slave\win_x64_gn__dbg_\build\src\content\public\child\fixed_received_data.cc(34) :error C2220: warning treated as error - no 'object' file generated e:\b\build\slave\win_x64_gn__dbg_\build\src\content\public\child\fixed_received_data.cc(34) : warning C4267: 'return' : conversion from 'size_t' to 'int', possible loss of data Original issue's description: > Make WebURLLoader capable of retaining received buffers. > > In order to implement backpressure on resource loading, this CL > makes WebURLLoader capable of retaining received buffers. In the > current implementation, ResourceDispatcher takes care of the buffer > lifetime in OnReceivedData. With this CL, it passes a ReceivedData > object that contains payload, length and encoded_length. The difference > is that a ReceivedData object keeps payload valid while it is alive, > so we can store the buffer if we like (with care, of course). > > This CL does not change the behavior, except one: it replaces a possible > use-after-free in ResourceDispatcher::OnReceivedData when using > |alternative_data| with |threaded_data_provider| with an incorrect > , but safe operation. > > BUG=480746 > > Committed: https://crrev.com/65d393906dd7532c51bbb70c9c181eae3b1e1758 > Cr-Commit-Position: refs/heads/master@{#332512} TBR=jochen@chromium.org,tyoshino@chromium.org,yhirano@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480746 Committed: https://crrev.com/801852861659d8e3411695473884c785868e970b Cr-Commit-Position: refs/heads/master@{#332520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -656 lines) Patch
M chrome/renderer/extensions/extension_localization_peer.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_localization_peer.cc View 3 chunks +7 lines, -22 lines 0 comments Download
M chrome/renderer/extensions/extension_localization_peer_unittest.cc View 9 chunks +11 lines, -23 lines 0 comments Download
M chrome/renderer/security_filter_peer.h View 4 chunks +9 lines, -5 lines 0 comments Download
M chrome/renderer/security_filter_peer.cc View 6 chunks +16 lines, -11 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M content/child/resource_dispatcher.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/child/resource_dispatcher.cc View 5 chunks +18 lines, -31 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 2 chunks +8 lines, -4 lines 0 comments Download
D content/child/shared_memory_received_data_factory.h View 1 chunk +0 lines, -67 lines 0 comments Download
D content/child/shared_memory_received_data_factory.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D content/child/shared_memory_received_data_factory_unittest.cc View 1 chunk +0 lines, -224 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 6 chunks +12 lines, -14 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 5 chunks +5 lines, -9 lines 0 comments Download
M content/content_child.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/child/fixed_received_data.h View 1 chunk +0 lines, -37 lines 0 comments Download
D content/public/child/fixed_received_data.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M content/public/child/request_peer.h View 3 chunks +6 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
Created Revert of Make WebURLLoader capable of retaining received buffers.
5 years, 6 months ago (2015-06-03 01:13:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159113009/1
5 years, 6 months ago (2015-06-03 01:14:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 01:18:35 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 01:19:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/801852861659d8e3411695473884c785868e970b
Cr-Commit-Position: refs/heads/master@{#332520}

Powered by Google App Engine
This is Rietveld 408576698