Sync event interfaces with the UI Events spec

Source/core/events/MouseEvent.idl

 /*
  * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
-// http://www.w3.org/TR/DOM-Level-3-Events/#interface-MouseEvent
+// https://w3c.github.io/uievents/#interface-MouseEvent
 
 [
     Constructor(DOMString type, optional MouseEventInit eventInitDict),
     ConstructorCallWith=ScriptState,
 ] interface MouseEvent : UIEvent {
     readonly attribute long             screenX;
     readonly attribute long             screenY;
     readonly attribute long             clientX;
     readonly attribute long             clientY;
     readonly attribute boolean          ctrlKey;
     readonly attribute boolean          shiftKey;
     readonly attribute boolean          altKey;
     readonly attribute boolean          metaKey;
+    // TODO(philipj): button should be short, not unsigned short.

[Rick Byers, 2015/06/03 13:42:13]

note I believe this was a change as a result of pointer events (where a -1 value
was added only on PointerEvent instances which are a subclass of MouseEvent) and
the consensus was that it should be sufficiently web compatible.

I'd consider such a change in IDL to be 'trivial' and so something we could
probably do without a formal intent process or anything.  Still best to keep out
of this CL, but maybe you or mustaq (cc'd) want to land a tiny CL to do that
after this one lands? 

[philipj_slow, 2015/06/03 14:40:48]

I agree that this kind of thing doesn't need an intent to implement (or ship).
I've been doing the spec sync work by avoiding observable or non-trivial changes
in the initial sync. I fix some things in follow-up, but far from all, but I
hope to make small fixes like this my side project once I've finished the
initial sweep. Figuring out which changes are web compatible would be years of
work, so I certainly can't do it all myself.

[Rick Byers, 2015/06/03 14:50:29]

Yes, plus IMHO your time is much better spent providing guidance / review to
leverage your expertise here.  We can certainly get people to help - let's
discuss more offline.

     readonly attribute unsigned short   button;
     readonly attribute unsigned short   buttons;
     readonly attribute EventTarget?     relatedTarget;
-    [MeasureAs=MouseEventMovementX] readonly attribute long             movementX;
-    [MeasureAs=MouseEventMovementY] readonly attribute long             movementY;
-    [MeasureAs=PrefixedMouseEventMovementX, ImplementedAs=movementX] readonly attribute long webkitMovementX;
-    [MeasureAs=PrefixedMouseEventMovementY, ImplementedAs=movementY] readonly attribute long webkitMovementY;
+    // TODO(philipj): boolean getModifierState(DOMString keyArg);

[Rick Byers, 2015/06/03 13:42:13]

I wonder if we should be filing Available bugs for each of these unimplemented
APIs?  Some of them may be be a good opportunity for someone getting started in
blink.  I guess searching all IDL files for 'TODO' should be a good way of
finding all such potential work, so perhaps that's sufficient.  WDYT?  Did you
have concrete plans for next steps for things like this?

[philipj_slow, 2015/06/03 14:40:48]

Some missing thing could be trivial, but I suspect that a large proportion of
missing things on old interfaces require looking into the history of the
interfaces, current browser support and web compat concerns. That would be a
terrible first experience with Blink, but in specific cases we could do it. Do
you think this one in particular would be easy to fix?

[Rick Byers, 2015/06/03 14:50:29]

Yeah many are non-trivial but still somewhat formulaic (compare behavior on
other browsers, etc.).  This one, for example, is probably simpler than the
addition of 'key' and 'code' that's being driven by a Samsung engineer right
now.

 
-     [CallWith=ScriptState] void initMouseEvent([Default=Undefined] optional DOMString type,
-                                       [Default=Undefined] optional boolean canBubble,
+    // https://w3c.github.io/uievents/#idl-interface-MouseEvent-initializers
+    // TODO(philipj): None of the initMouseEvent() arguments should be optional.
+    [CallWith=ScriptState] void initMouseEvent([Default=Undefined] optional DOMString type,
+                                       [Default=Undefined] optional boolean bubbles,
                                        [Default=Undefined] optional boolean cancelable,
-                                       [Default=Undefined] optional Window view,
+                                       [Default=Undefined] optional Window? view,
                                        [Default=Undefined] optional long detail,
                                        [Default=Undefined] optional long screenX,
                                        [Default=Undefined] optional long screenY,
                                        [Default=Undefined] optional long clientX,
                                        [Default=Undefined] optional long clientY,
                                        [Default=Undefined] optional boolean ctrlKey,
                                        [Default=Undefined] optional boolean altKey,
                                        [Default=Undefined] optional boolean shiftKey,
                                        [Default=Undefined] optional boolean metaKey,
                                        [Default=Undefined] optional unsigned short button,
-                                       [Default=Undefined] optional EventTarget relatedTarget);
+                                       [Default=Undefined] optional EventTarget? relatedTarget);
+
+    // Pointer Lock
+    // https://dvcs.w3.org/hg/pointerlock/raw-file/default/index.html#extensions-to-the-mouseevent-interface
+    [MeasureAs=MouseEventMovementX] readonly attribute long movementX;
+    [MeasureAs=MouseEventMovementY] readonly attribute long movementY;
 
     // Non-standard
     [MeasureAs=MouseEventOffsetX] readonly attribute long offsetX;
     [MeasureAs=MouseEventOffsetY] readonly attribute long offsetY;
     [MeasureAs=MouseEventX] readonly attribute long x;
     [MeasureAs=MouseEventY] readonly attribute long y;
     [MeasureAs=MouseEventFromElement] readonly attribute Node fromElement;
     [MeasureAs=MouseEventToElement] readonly attribute Node toElement;
     [MeasureAs=MouseEventWhich] readonly attribute long which;
+    [MeasureAs=PrefixedMouseEventMovementX, ImplementedAs=movementX] readonly attribute long webkitMovementX;
+    [MeasureAs=PrefixedMouseEventMovementY, ImplementedAs=movementY] readonly attribute long webkitMovementY;
 
     // FIXME: this belongs on the DragEvent interface
     readonly attribute DataTransfer dataTransfer;
 };