chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java - Issue 1159113006: [Android] A prototype of the interactive media notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

Issue 1159113006: [Android] A prototype of the interactive media notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Ted's comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/media/ui/NotificationMediaPlaybackControls.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/media/ui/NotificationMediaPlaybackControls.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | content/browser/media/android/media_session.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

index 9b1fef45e58183863bd520f256d24832c87273fe..87609d6b2a74b8a37816eba6f803c8524371306f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

@@ -49,6 +49,7 @@ import org.chromium.chrome.browser.externalnav.ExternalNavigationHandler.Overrid

import org.chromium.chrome.browser.externalnav.ExternalNavigationParams;

import org.chromium.chrome.browser.fullscreen.FullscreenManager;

import org.chromium.chrome.browser.media.MediaNotificationService;

+import org.chromium.chrome.browser.media.ui.MediaSessionTabHelper;

import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;

import org.chromium.chrome.browser.ntp.NativePageAssassin;

import org.chromium.chrome.browser.ntp.NativePageFactory;

@@ -95,7 +96,7 @@ import java.util.Locale;

public class ChromeTab extends Tab {

public static final int NTP_TAB_ID = -2;

- private static final String TAG = "ChromeTab";

+ private static final String TAG = "cr.ChromeTab";

// URL didFailLoad error code. Should match the value in net_error_list.h.

public static final int BLOCKED_BY_ADMINISTRATOR = -22;

@@ -230,6 +231,7 @@ public class ChromeTab extends Tab {

ContextualSearchTabHelper.createForTab(this);

if (nativeWindow != null) ThumbnailTabHelper.createForTab(this);

+ MediaSessionTabHelper.createForTab(this);

}

/**