chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java - Issue 1159113006: [Android] A prototype of the interactive media notification.

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

Issue 1159113006: [Android] A prototype of the interactive media notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added some null checks and hiding the notification when the tab is destroyed. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/media/ui/NotificationMediaPlaybackControls.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/media/ui/NotificationMediaPlaybackControls.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

index 4376bbee5eaea3e851f3d20637bc611d110aa324..69a7d88f066104aa8cc09e97bb69b9fcfe7cad7f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

@@ -49,6 +49,7 @@ import org.chromium.chrome.browser.externalnav.ExternalNavigationHandler.Overrid

import org.chromium.chrome.browser.externalnav.ExternalNavigationParams;

import org.chromium.chrome.browser.fullscreen.FullscreenManager;

import org.chromium.chrome.browser.media.MediaNotificationService;

+import org.chromium.chrome.browser.media.ui.MediaSessionTabHelper;

import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;

import org.chromium.chrome.browser.ntp.NativePageAssassin;

import org.chromium.chrome.browser.ntp.NativePageFactory;

@@ -95,7 +96,7 @@ import java.util.Locale;

public class ChromeTab extends Tab {

public static final int NTP_TAB_ID = -2;

- private static final String TAG = "ChromeTab";

+ private static final String TAG = "cr.ChromeTab";

// URL didFailLoad error code. Should match the value in net_error_list.h.

public static final int BLOCKED_BY_ADMINISTRATOR = -22;

@@ -230,6 +231,7 @@ public class ChromeTab extends Tab {

ContextualSearchTabHelper.createForTab(this);

if (nativeWindow != null) ThumbnailTabHelper.createForTab(this);

+ MediaSessionTabHelper.createForTab(this);

qinmin 2015/07/04 19:30:46 do we need to check nativeWindow here too?

whywhat 2015/07/06 17:38:24 Ted, what do you think? What's the difference bet

}

/**

@@ -571,6 +573,7 @@ public class ChromeTab extends Tab {

private boolean hasAudibleAudio() {

return !isClosing() && super.nativeHasAudibleAudio(getWebContents());

}

qinmin 2015/07/04 19:30:46 nit: remote this

whywhat 2015/07/06 17:38:24 Done.

}

/**