[Android] A prototype of the interactive media notification.

content/public/browser/web_contents_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 
 #include <set>
 #include <string>
 
@@ skipping 387 matching lines @@
                          int active_match_ordinal,
                          bool final_update) {}
 
 #if defined(OS_ANDROID)
   // Provides the rects of the current find-in-page matches.
   // Sent as a reply to RequestFindMatchRects.
   virtual void FindMatchRectsReply(WebContents* web_contents,
                                    int version,
                                    const std::vector<gfx::RectF>& rects,
                                    const gfx::RectF& active_rect) {}
+
+  // Notifies the tab that the state relevant to the media controls has changed.
+  virtual void UpdateMediaControls(WebContents* web_contents) {}

[Ted C, 2015/06/26 00:43:55]

Why does this exist here?

WebContentsObserver already has methods MediaStartedPlaying & MediaPaused.  I'm
not a big fan of having this exist in the delegate and the observer for very
similar functionality.

I would rather us make the observer more robust to ensure it covers the cases
you are trying to accomplish (or just ensuring the two above methods are called
when appropriate).

[whywhat, 2015/06/26 19:29:32]

So these methods are only used for Chromecast as far as I can see and we don't
really bind the media controls notification to a single player playing/paused.
So MediaSession from media_session.cc would call something like
WebContents::MediaSessionChanged() and that would notify the
WebContentsObservers that would use the MediaControlsDelegate to get what they
need and update the controls.

WDYT?
Where would I initialize such an observer in Chrome for Android?

[Ted C, 2015/06/30 04:56:13]

The problem I have with it being in both WebContentsDelegate and
WebContentsObserver is that embedders of the content layer have no real idea of
when to use one or the other.

If the existing ones are in WebContentsObserver, I would rather be consistent
and add further clarification of when to use one over the other.
You would initialize it in Tab/ChromeTab.  There are already a few examples of
an self contained observer that is a good example of what I'm referring to.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/jav...
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/jav...

That is really the example of how I would like to see the chrome side
implemented.

Even if the WebContentsDelegate approach is what needs to be done, you could add
a TabObserver method to still keep the bulk of the code out of the tab logic
itself.

 #endif
 
   // Invoked when the preferred size of the contents has been changed.
   virtual void UpdatePreferredSize(WebContents* web_contents,
                                    const gfx::Size& pref_size) {}
 
   // Invoked when the contents auto-resized and the container should match it.
   virtual void ResizeDueToAutoResize(WebContents* web_contents,
                                      const gfx::Size& new_size) {}
 
@@ skipping 89 matching lines @@
   // Called when |this| is no longer the WebContentsDelegate for |source|.
   void Detach(WebContents* source);
 
   // The WebContents that this is currently a delegate for.
   std::set<WebContents*> attached_contents_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_