[Android] A prototype of the interactive media notification.

chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaPlaybackListener.java

+// Copyright 2013 The Chromium Authors. All rights reserved.

[mlamouri (slow - plz ping), 2015/06/23 14:58:56]

2015

[whywhat, 2015/06/23 19:39:11]

Ack.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.media.ui;
+
+/**
+ * Listener for media playback events that are relevant to the browser UI.
+ */
+public interface MediaPlaybackListener {

[mlamouri (slow - plz ping), 2015/06/23 14:58:56]

I think you should only keep this interface if there is an obvious other
consumer. Otherwise, it sounds like a lot of indirection.

[whywhat, 2015/06/23 19:39:11]

Ack.

+    /**
+     * Called when the media playback state has changed (e.g. from playing to paused)
+     * @param isPaused the new state (see {@link MediaInfo#isPaused})
+     */
+    void onPlaybackStateChanged(boolean isPaused);

[mlamouri (slow - plz ping), 2015/06/23 14:58:56]

Maybe an int with final values would be better? PAUSE/PLAY.
onPlaybackStateChanged(true) doesn't mean anything unless you go look at that
file.

[whywhat, 2015/06/23 19:39:11]

You suggested that I change from PlaybackState enum-like constants to a boolean
:) Now you don't like it here.
Maybe I should have onResumed/onPaused.

+
+    /**
+     * Called if the title of the media changes
+     * @param title the new title
+     */
+    void onTitleChanged(String title);
+
+    /**
+     * Called if the origin of the tab containing media changes.
+     * @param origin the new origin
+     */
+    void onOriginChanged(String origin);
+
+    /**
+     * Called if the id of the tab containing the media changed.
+     * @param tabId the new tab id
+     */
+    void onTabIdChanged(int tabId);
+}