Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: tools/testing/dart/test_progress.dart

Issue 11591017: Revert "Call DumpRenderTree directly from test.dart instead of using the drt-trampoline.py indirect… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_progress.dart
diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart
index 203edbdd195cc33250eaef829dd273bce1f6f720..f23b0979b4abf1563df2ad7fc049477e670271f3 100644
--- a/tools/testing/dart/test_progress.dart
+++ b/tools/testing/dart/test_progress.dart
@@ -148,7 +148,7 @@ class ProgressIndicator {
}
_failureSummary.addAll(failureOutput);
}
-
+
List<String> _buildFailureOutput(TestCase test) {
List<String> output = new List<String>();
output.add('');
@@ -183,17 +183,16 @@ class ProgressIndicator {
if (!test.lastCommandOutput.stdout.isEmpty) {
output.add('');
output.add('stdout:');
- if (test.lastCommandOutput.command.isPixelTest) {
- output.add('DRT pixel test failed! stdout is not printed because it '
- 'contains binary data!');
- } else {
- output.add(new String.fromCharCodes(test.lastCommandOutput.stdout));
+ for (var s in test.lastCommandOutput.stdout) {
+ output.add(s);
}
}
if (!test.lastCommandOutput.stderr.isEmpty) {
output.add('');
output.add('stderr:');
- output.add(new String.fromCharCodes(test.lastCommandOutput.stderr));
+ for (var s in test.lastCommandOutput.stderr) {
+ output.add(s);
+ }
}
for (Command c in test.commands) {
output.add('');
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698