Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 11591013: Setting audio volume is no longer ignored on low latency audio path for Mac. (Closed)

Created:
8 years ago by henrika (OOO until Aug 14)
Modified:
8 years ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, sail+watch_chromium.org, Chris Rogers, scherkus (not reviewing)
Visibility:
Public.

Description

Setting audio volume is no longer ignored on low latency audio path for Mac. Note that Mac is (was) the only platform that did not use the volume level for the low-latency output path. This discrepancy is now removed. This change should not affect the audio/video tag or any other audio client as far as I can tell. TBR=dalecurtis BUG=166394 TEST=Run this https://code.google.com/p/webrtc-samples/source/browse/trunk/demos/html/local-audio-rendering.html on Mac and verify that volume settings works. Also executed: media_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173452

Patch Set 1 #

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M media/audio/mac/audio_low_latency_output_mac.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698