Issue 11591006: Track input latency with UMA stats

Issue 11591006: Track input latency with UMA stats (Closed)

Created:
8 years ago by DaveMoore

Modified:
7 years, 11 months ago

Reviewers:
sadrul, Ben Goodger (Google)

CC:
chromium-reviews, jennb, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, Dmitry Titov, jianli, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dcheng, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Track input latency with UMA stats BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175386

Patch Set 1 #

Patch Set 2 : Fix indenting #

Patch Set 3 : Missed headers for tests #

Patch Set 4 : Missed a test include #

Total comments: 2

Patch Set 5 : Added per event type histograms #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+245 lines, -100 lines)			Patch
M	ash/drag_drop/drag_drop_controller.cc	View	1 2 3 4	2 chunks	+9 lines, -3 lines	0 comments	Download
M	ash/drag_drop/drag_drop_controller_unittest.cc	View	1 2 3 4	2 chunks	+9 lines, -3 lines	0 comments	Download
M	ash/wm/custom_frame_view_ash_unittest.cc	View	1 2	2 chunks	+8 lines, -3 lines	0 comments	Download
M	ash/wm/system_gesture_event_filter_unittest.cc	View	1 2 3 4	7 chunks	+21 lines, -14 lines	0 comments	Download
M	ash/wm/window_manager_unittest.cc	View	1 2 3 4	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_browsertest.cc	View	1 2 3 4	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	1 2 3 4	3 chunks	+5 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura_unittest.cc	View	1 2	3 chunks	+25 lines, -12 lines	0 comments	Download
M	content/renderer/render_widget.cc	View	1 2 3 4	2 chunks	+61 lines, -0 lines	0 comments	Download
M	ui/aura/gestures/gesture_recognizer_unittest.cc	View	1 2 3 4	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/aura/test/event_generator.cc	View		6 chunks	+12 lines, -9 lines	0 comments	Download
M	ui/aura/window_unittest.cc	View	1 2 3 4	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/base/events/event.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/events/event.cc	View	1 2 3 4	6 chunks	+70 lines, -46 lines	0 comments	Download
M	ui/base/events/event_utils.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/base/events/event_utils.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/base/gestures/gesture_recognizer_impl.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	ui/views/corewm/compound_event_filter_unittest.cc	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sadrul

LGTM Are there plans to measure the latency separately for each kind of event? https://codereview.chromium.org/11591006/diff/17002/content/renderer/render_widget.cc ...

8 years ago (2012-12-19 19:14:04 UTC) #2

DaveMoore

Added histograms for each event type as well. https://codereview.chromium.org/11591006/diff/17002/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/11591006/diff/17002/content/renderer/render_widget.cc#newcode566 content/renderer/render_widget.cc:566: On ...

7 years, 11 months ago (2013-01-07 19:43:42 UTC) #3

lgtm

Expand Messages | Collapse Messages