Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1159063004: Support running with mojo:debugger in devtools. (Closed)

Created:
5 years, 6 months ago by ppi
Modified:
5 years, 6 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Address Ben's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -9 lines) Patch
M mojo/devtools/common/devtoolslib/android_shell.py View 3 chunks +28 lines, -9 lines 0 comments Download
M mojo/devtools/common/devtoolslib/linux_shell.py View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell.py View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_arguments.py View 1 2 chunks +16 lines, -0 lines 0 comments Download
M mojo/tools/android_mojo_shell.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ppi
Hi Ben, ptal.
5 years, 6 months ago (2015-06-03 09:19:20 UTC) #4
qsr
LGTM with nit. https://codereview.chromium.org/1159063004/diff/40001/mojo/devtools/common/devtoolslib/shell_arguments.py File mojo/devtools/common/devtoolslib/shell_arguments.py (right): https://codereview.chromium.org/1159063004/diff/40001/mojo/devtools/common/devtoolslib/shell_arguments.py#newcode82 mojo/devtools/common/devtoolslib/shell_arguments.py:82: 'mojo:debugger'] If you plan to run ...
5 years, 6 months ago (2015-06-03 10:38:20 UTC) #5
ppi
https://codereview.chromium.org/1159063004/diff/40001/mojo/devtools/common/devtoolslib/shell_arguments.py File mojo/devtools/common/devtoolslib/shell_arguments.py (right): https://codereview.chromium.org/1159063004/diff/40001/mojo/devtools/common/devtoolslib/shell_arguments.py#newcode82 mojo/devtools/common/devtoolslib/shell_arguments.py:82: 'mojo:debugger'] On 2015/06/03 10:38:19, qsr wrote: > If you ...
5 years, 6 months ago (2015-06-03 10:43:13 UTC) #6
ppi
5 years, 6 months ago (2015-06-03 10:44:13 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:50001) manually as
bc8e3d08146957c09872aec2830107fb0628d5c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698