Start a renderer-initiated navigation before commit in RendererInitiatedPendingEntries

content/browser/frame_host/navigation_controller_impl_unittest.cc

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc
index e325c91d24e16e66d9f9f29306601f8258786ef8..a59130804752c673996ba8a71f1eaac9019218c5 100644
--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc
@@ -3251,6 +3251,8 @@ TEST_F(NavigationControllerTest, RendererInitiatedPendingEntries) {
 
   // We create pending entries for renderer-initiated navigations so that we
   // can show them in new tabs when it is safe.
+  main_test_rfh()->SendRendererInitiatedNavigationRequest(url1, false);
+  main_test_rfh()->PrepareForCommit();

[Charlie Reis, 2015/05/28 17:02:27]

These two lines are only needed for PlzNavigate, right?  There's no interactions
with the browser process before DidStartProvisionalLoad by default, and the
BeforeUnload_ACK in PrepareForCommit isn't used for renderer-initiated
navigations.

[nasko, 2015/05/28 17:16:44]

While they are fairly PlzNavigate specific, in my unit tests CL I've added
initialization of the RenderFrame as the first step in
SendRendererInitiatedNavigationRequest. I could manually do it, but it seemed
better to write it in a way that is compatible with PlzNavigate style
navigation.

I could drop the PrepareForCommit. In general I have been aiming for more
streamlined flow of calls that are consistent, logical and don't force you to
know all the intricate details of each call.

[Charlie Reis, 2015/05/28 17:40:19]

Ok.
Hmm, there's a tradeoff here.  We're already running into problems where the
unit tests don't match reality, and this introduces another case
(BeforeUnload_ACK).  I'm ok with it in this case, though, since we need to be
able to handle that message and it does make writing the tests easier.

   navigator->DidStartProvisionalLoad(main_test_rfh(), url1);
 
   // Simulate what happens if a BrowserURLHandler rewrites the URL, causing