Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc

Issue 1159033008: Refactor ViewsDelegate singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
diff --git a/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc b/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
index 9a626d69146268a7a82e69b0bd94cc5d579cd7cc..a9445f5721a155f6187901c9f03b9afa9643e356 100644
--- a/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
+++ b/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
@@ -16,6 +16,7 @@
#include "ui/events/test/event_generator.h"
#include "ui/gfx/screen.h"
#include "ui/views/test/test_views.h"
+#include "ui/views/test/test_views_delegate.h"
#include "ui/views/test/views_test_base.h"
#include "ui/views/test/widget_test.h"
#include "ui/views/widget/widget.h"
@@ -364,7 +365,7 @@ class DesktopAuraTopLevelWindowTest
typedef WidgetTest DesktopAuraWidgetTest;
TEST_F(DesktopAuraWidgetTest, FullscreenWindowDestroyedBeforeOwnerTest) {
- ViewsDelegate::views_delegate = NULL;
+ set_views_delegate(nullptr);
DesktopAuraTopLevelWindowTest fullscreen_window;
ASSERT_NO_FATAL_FAILURE(fullscreen_window.CreateTopLevelWindow(
gfx::Rect(0, 0, 200, 200), true));
@@ -375,7 +376,7 @@ TEST_F(DesktopAuraWidgetTest, FullscreenWindowDestroyedBeforeOwnerTest) {
}
TEST_F(DesktopAuraWidgetTest, FullscreenWindowOwnerDestroyed) {
- ViewsDelegate::views_delegate = NULL;
+ set_views_delegate(nullptr);
DesktopAuraTopLevelWindowTest fullscreen_window;
ASSERT_NO_FATAL_FAILURE(fullscreen_window.CreateTopLevelWindow(
@@ -387,7 +388,7 @@ TEST_F(DesktopAuraWidgetTest, FullscreenWindowOwnerDestroyed) {
}
TEST_F(DesktopAuraWidgetTest, TopLevelOwnedPopupTest) {
- ViewsDelegate::views_delegate = NULL;
+ set_views_delegate(nullptr);
DesktopAuraTopLevelWindowTest popup_window;
ASSERT_NO_FATAL_FAILURE(popup_window.CreateTopLevelWindow(
gfx::Rect(0, 0, 200, 200), false));
@@ -400,7 +401,7 @@ TEST_F(DesktopAuraWidgetTest, TopLevelOwnedPopupTest) {
// This test validates that when a top level owned popup Aura window is
// resized, the widget is resized as well.
TEST_F(DesktopAuraWidgetTest, TopLevelOwnedPopupResizeTest) {
- ViewsDelegate::views_delegate = NULL;
+ set_views_delegate(nullptr);
DesktopAuraTopLevelWindowTest popup_window;
popup_window.set_use_async_mode(false);
@@ -420,7 +421,7 @@ TEST_F(DesktopAuraWidgetTest, TopLevelOwnedPopupResizeTest) {
// This test validates that when a top level owned popup Aura window is
// repositioned, the widget is repositioned as well.
TEST_F(DesktopAuraWidgetTest, TopLevelOwnedPopupRepositionTest) {
- ViewsDelegate::views_delegate = NULL;
+ set_views_delegate(nullptr);
DesktopAuraTopLevelWindowTest popup_window;
popup_window.set_use_async_mode(false);

Powered by Google App Engine
This is Rietveld 408576698