Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(141)

Issue 1159003006: Oilpan: Make PersistentNode hold a raw pointer (Closed)

Created:
4 years, 11 months ago by haraken
Modified:
4 years, 11 months ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Make PersistentNode hold a raw pointer This CL changes: class PersistentNode { }; class PersistentBase : public PersistentNode { }; class Persistent { T* m_raw; }; class CrossThreadPersistent { T* m_raw; }; to: class PersistentNode { void* m_raw; }; class PersistentBase : public PersistentNode { }; class Persistent { }; class CrossThreadPersistent { }; This is a preparation for tracing the m_raw from PersistentNode and thus remove PersistentNode::m_trace in a follow-up CL. BUG=483380 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196501

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -67 lines) Patch
M Source/platform/heap/Handle.h View 1 2 3 4 22 chunks +79 lines, -67 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
haraken
PTAL
4 years, 11 months ago (2015-06-03 13:29:54 UTC) #2
keishi
lgtm
4 years, 11 months ago (2015-06-03 14:47:11 UTC) #3
haraken
Fixed test failures. Landing.
4 years, 11 months ago (2015-06-04 04:25:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159003006/40001
4 years, 11 months ago (2015-06-04 04:26:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65206)
4 years, 11 months ago (2015-06-04 05:12:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159003006/80001
4 years, 11 months ago (2015-06-04 12:43:47 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 13:56:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196501

Powered by Google App Engine
This is Rietveld 408576698