Issue 11590013: [filemanager] Decode escaped url in action choice dialog open code.

Issue 11590013: [filemanager] Decode escaped url in action choice dialog open code. (Closed)

Created:
8 years ago by dgozman

Modified:
8 years ago

Reviewers:
Vladislav Kaznacheev

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[filemanager] Decode escaped url in action choice dialog open code. BUG=163436 TEST=See bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173446

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/resources/file_manager/js/action_choice.js	View		1 chunk	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

lgtm https://codereview.chromium.org/11590013/diff/1/chrome/browser/resources/file_manager/js/action_choice.js File chrome/browser/resources/file_manager/js/action_choice.js (right): https://codereview.chromium.org/11590013/diff/1/chrome/browser/resources/file_manager/js/action_choice.js#newcode53 chrome/browser/resources/file_manager/js/action_choice.js:53: ActionChoice.instance = new ActionChoice(dom, filesystem, params); Why in ...

8 years ago (2012-12-17 09:21:49 UTC) #2

dgozman

https://codereview.chromium.org/11590013/diff/1/chrome/browser/resources/file_manager/js/action_choice.js File chrome/browser/resources/file_manager/js/action_choice.js (right): https://codereview.chromium.org/11590013/diff/1/chrome/browser/resources/file_manager/js/action_choice.js#newcode53 chrome/browser/resources/file_manager/js/action_choice.js:53: ActionChoice.instance = new ActionChoice(dom, filesystem, params); On 2012/12/17 09:21:49, ...

8 years ago (2012-12-17 10:08:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/11590013/1

8 years ago (2012-12-17 10:08:39 UTC) #4

Message was sent while issue was closed.

Change committed as 173446

Expand Messages | Collapse Messages