Issue 1158983005: Implement Container in fn2

Issue 1158983005: Implement Container in fn2 (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Implement Container in fn2 This CL is a first pass at implementing container in fn2. In this approach, Container is a Component that builds a number of RenderNodeWrappers depending on what is needed. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2856feacfb5082a445b54e530e39f2572736d93d

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 7

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -15 lines)			Patch
M	sky/examples/fn2/container.dart	View		1 chunk	+13 lines, -1 line	2 comments	Download
M	sky/sdk/lib/framework/components2/scaffold.dart	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/sdk/lib/framework/fn2.dart	View		2 chunks	+103 lines, -0 lines	1 comment	Download
M	sky/sdk/lib/framework/rendering/box.dart	View	1	3 chunks	+26 lines, -10 lines	2 comments	Download
M	sky/tests/raw/render_flex.dart	View		1 chunk	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hixie

lgtm https://codereview.chromium.org/1158983005/diff/20001/sky/examples/fn2/container.dart File sky/examples/fn2/container.dart (right): https://codereview.chromium.org/1158983005/diff/20001/sky/examples/fn2/container.dart#newcode17 sky/examples/fn2/container.dart:17: desiredSize: new sky.Size(double.INFINITY, 100.0), why not desiredWidth and ...

5 years, 6 months ago (2015-06-02 21:52:22 UTC) #2

abarth-chromium

Committed patchset #2 (id:20001) manually as 2856feacfb5082a445b54e530e39f2572736d93d (presubmit successful).

5 years, 6 months ago (2015-06-02 22:07:07 UTC) #3

abarth-chromium

5 years, 6 months ago (2015-06-02 22:32:21 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/1158983005/diff/20001/sky/sdk/lib/framework/r...
File sky/sdk/lib/framework/rendering/box.dart (right):

https://codereview.chromium.org/1158983005/diff/20001/sky/sdk/lib/framework/r...
sky/sdk/lib/framework/rendering/box.dart:193: markNeedsLayout();
On 2015/06/02 at 21:52:21, Hixie wrote:
> Why is this better?

We had two similar functions and they didn't match.  I added a third and had to
pick a winner.

https://codereview.chromium.org/1158983005/diff/20001/sky/tests/raw/render_fl...
File sky/tests/raw/render_flex.dart (right):

https://codereview.chromium.org/1158983005/diff/20001/sky/tests/raw/render_fl...
sky/tests/raw/render_flex.dart:75: flexRoot.add(new RenderPadding(padding: const
EdgeDims(10.0, 10.0, 10.0, 10.0),
On 2015/06/02 at 21:52:21, Hixie wrote:
> This can be const EdgeDims.all(10.0) now.

Done.

Expand Messages | Collapse Messages