IndexedDB: Rely on bindings for enum validation

IndexedDB: Rely on bindings for enum validation

When bindings grew enum support, a DOMString -> IDBCursorDirection
update was missed for IDBObjectStore's openCursor() method.

Also, now that generated code verifies enum values, remove the
failure cases from stringToXXX() methods.

BUG=358067
R=cmumford@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196358

[jsbell, 2015-06-02 19:01:08]

cmumford@ - please take a look?

https://codereview.chromium.org/1158973007/diff/40001/LayoutTests/storage/ind...
File LayoutTests/storage/indexeddb/exceptions-expected.txt (right):

https://codereview.chromium.org/1158973007/diff/40001/LayoutTests/storage/ind...
LayoutTests/storage/indexeddb/exceptions-expected.txt:275: PASS
store.openCursor(0, 'invalid-direction') threw TypeError: Failed to execute
'openCursor' on 'IDBObjectStore': The provided value 'invalid-direction' is not
a valid enum value of type IDBCursorDirection.
Message is less helpful, but this is what we do for all enums.

https://codereview.chromium.org/1158973007/diff/40001/Source/modules/indexedd...
File Source/modules/indexeddb/IDBDatabase.cpp (right):

https://codereview.chromium.org/1158973007/diff/40001/Source/modules/indexedd...
Source/modules/indexeddb/IDBDatabase.cpp:293: if (mode !=
WebIDBTransactionModeReadOnly && mode != WebIDBTransactionModeReadWrite) {
Written this way instead of (mode == WebIDBTransactionVersionChange) in
anticipation of future transaction types.

https://codereview.chromium.org/1158973007/diff/40001/Source/modules/indexedd...
Source/modules/indexeddb/IDBDatabase.cpp:294: exceptionState.throwTypeError("The
mode provided ('" + modeString + "') is not one of 'readonly' or 'readwrite'.");
And similarly, this could be changed to e.g. "You can't create 'versionchange'
transactions by hand." but leaving the existing message as-is for now.

[cmumford, 2015-06-02 21:05:56]

lgtm

[jsbell, 2015-06-02 22:22:41]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2015-06-02 22:23:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158973007/40001

[commit-bot: I haz the power, 2015-06-02 22:29:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 22:29:36]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[jsbell, 2015-06-02 22:31:38]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2015-06-02 22:31:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
cmumford@chromium.org
Link to the patchset: https://codereview.chromium.org/1158973007/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2015-06-02 22:32:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158973007/60001

[commit-bot: I haz the power, 2015-06-02 23:53:23]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196358