icu.gyp - Issue 1158933005: Remove unnecessary clang flags for ICU

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: icu.gyp

Issue 1158933005: Remove unnecessary clang flags for ICU (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: icu.gyp

diff --git a/icu.gyp b/icu.gyp

index 910fe68e6f94189f10b1db778f961950f69360ed..8b336e96659fb88108cf9eb1200f102d78f9db0f 100644

--- a/icu.gyp

+++ b/icu.gyp

@@ -198,8 +198,6 @@

'-Wno-logical-op-parentheses',

# ICU has some `unsigned < 0` checks.

'-Wno-tautological-compare',

Nico 2015/05/28 02:33:52 Since the .gn file doesn't have it, you might be a

jungshik at Google 2015/05/28 18:10:19 BUILD.gn has both of them under |config("icu_code"

- # Looks like a real issue, see http://crbug.com/114660

- '-Wno-return-type-c-linkage',

# Since ICU wants to internally use its own deprecated APIs, don't

« BUILD.gn ('K') | « BUILD.gn ('k') | no next file » | no next file with comments »