Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: sky/sdk/lib/framework/app.dart

Issue 1158933004: In Sky framework AppView, cache the hit test result for pointer events and continue using that resu… (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/app.dart
diff --git a/sky/sdk/lib/framework/app.dart b/sky/sdk/lib/framework/app.dart
index 4c105715d9f6a9c19f4fb36d5fd23fa2ec7c1d3b..b25208a94bfd098640b583bd5f603b1fd2aa8620 100644
--- a/sky/sdk/lib/framework/app.dart
+++ b/sky/sdk/lib/framework/app.dart
@@ -14,21 +14,42 @@ class AppView {
_renderView = new RenderView(root: root);
_renderView.layout(newWidth: sky.view.width, newHeight: sky.view.height);
+ _hitTestResultForPointer = new Map<int, HitTestResult>();
abarth-chromium 2015/05/27 18:13:19 You can actually do this work on line 24 directly.
+
sky.view.scheduleFrame();
}
RenderView _renderView;
+ Map<int, HitTestResult> _hitTestResultForPointer;
abarth-chromium 2015/05/27 18:13:19 final Map<int, HitTestResult> _hitTestResultForPoi
+
void _beginFrame(double timeStamp) {
RenderNode.flushLayout();
_renderView.paintFrame();
}
void _handleEvent(sky.Event event) {
- if (event is! sky.PointerEvent)
- return;
- HitTestResult result = new HitTestResult();
- _renderView.hitTest(result, x: event.x, y: event.y);
+ if (event is sky.PointerEvent)
+ _handlePointerEvent(event);
+ }
+
+ void _handlePointerEvent(sky.PointerEvent event) {
+ HitTestResult result;
+ switch(event.type) {
+ case 'pointerdown':
+ result = new HitTestResult();
+ _renderView.hitTest(result, x: event.x, y: event.y);
+ _hitTestResultForPointer[event.pointer] = result;
+ break;
+ case 'pointerup':
+ case 'pointercancel':
+ result = _hitTestResultForPointer[event.pointer];
+ _hitTestResultForPointer.remove(event.pointer);
+ break;
+ case 'pointermove':
+ result = _hitTestResultForPointer[event.pointer];
+ break;
+ }
result.path.reversed.forEach((RenderNode node) {
abarth-chromium 2015/05/27 18:13:19 I'd add an assert(result != null)
node.handlePointer(event);
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698