Issue 1158933004: In Sky framework AppView, cache the hit test result for pointer events and continue using that resu…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1158933004: In Sky framework AppView, cache the hit test result for pointer events and continue using that resu… (Closed)

Created:
5 years, 6 months ago by jackson

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

In Sky framework AppView, cache the hit test result for pointer events and continue using that result until pointerup or pointer cancel event is received R=abarth@chromium.org, abarth Committed: https://chromium.googlesource.com/external/mojo/+/e10628be028880b11ece62f275655dde81d9c14a

Patch Set 2 : CR feedback from Adam #

Patch Set 3 : Merge with master #

Patch Set 4 : fix merge conflict #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -5 lines)			Patch
	M	sky/sdk/lib/framework/app.dart	View	1 2 3	1 chunk	+24 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

LGTM https://codereview.chromium.org/1158933004/diff/1/sky/sdk/lib/framework/app.dart File sky/sdk/lib/framework/app.dart (right): https://codereview.chromium.org/1158933004/diff/1/sky/sdk/lib/framework/app.dart#newcode17 sky/sdk/lib/framework/app.dart:17: _hitTestResultForPointer = new Map<int, HitTestResult>(); You can actually ...

5 years, 6 months ago (2015-05-27 18:13:20 UTC) #2

jackson

5 years, 6 months ago (2015-05-28 00:49:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
e10628be028880b11ece62f275655dde81d9c14a (presubmit successful).