[strong] fix strong array, object prototypes

test/mjsunit/strong/literals.js

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Flags: --strong-mode --allow-natives-syntax
 // Flags: --harmony-arrow-functions --harmony-rest-parameters
 // Flags: --harmony-destructuring
 
 'use strict';
 
+let GeneratorFunctionPrototype = (function*(){}).__proto__;
+
+function assertStrongObject(o) {
+  assertTrue(%IsStrong(o));
+  assertSame(Object.prototype, o.__proto__);
+}
+
+function assertStrongArray(a) {
+  assertTrue(%IsStrong(a));
+  assertSame(Array.prototype, a.__proto__);
+}
+
+function assertStrongFunction(f) {
+  assertTrue(%IsStrong(f));
+  assertSame(Function.prototype, f.__proto__);
+}
+
+function assertStrongGenerator(g) {
+  assertTrue(%IsStrong(g));
+  assertSame(GeneratorFunctionPrototype, g.__proto__);
+}
+
 (function WeakObjectLiterals() {
   assertTrue(!%IsStrong({}));
   assertTrue(!%IsStrong({a: 0, b: 0}));
   assertTrue(!%IsStrong({a: [], b: {}}));
   assertTrue(!%IsStrong({a: [], b: {}}.a));
   assertTrue(!%IsStrong({a: [], b: {}}.b));
   assertTrue(!%IsStrong({a: {b: {c: {}}}}.a));
   assertTrue(!%IsStrong({a: {b: {c: {}}}}.a.b));
   assertTrue(!%IsStrong({a: {b: {c: {}}}}.a.b.c));
   assertTrue(!%IsStrong({f: function(){}}));
   assertTrue(!%IsStrong(Realm.eval(Realm.current(),
                                    "({f: function(){}})")));
 })();
 
 (function StrongObjectLiterals() {
   'use strong';
-  assertTrue(%IsStrong({}));
-  assertTrue(%IsStrong({a: 0, b: 0}));
-  assertTrue(%IsStrong({a: [], b: {}}));
-  assertTrue(%IsStrong({a: [], b: {}}.a));
-  assertTrue(%IsStrong({a: [], b: {}}.b));
-  assertTrue(%IsStrong({a: {b: {c: {}}}}.a));
-  assertTrue(%IsStrong({a: {b: {c: {}}}}.a.b));
-  assertTrue(%IsStrong({a: {b: {c: {}}}}.a.b.c));
+  assertStrongObject({});
+  assertStrongObject({a: 0, b: 0});
+  assertStrongObject({a: [], b: {}});
+  assertStrongArray({a: [], b: {}}.a);
+  assertStrongObject({a: [], b: {}}.b);
+  assertStrongObject({a: {b: {c: {}}}}.a);
+  assertStrongObject({a: {b: {c: {}}}}.a.b);
+  assertStrongObject({a: {b: {c: {}}}}.a.b.c);
   // Maps for literals with too many properties are not cached.
-  assertTrue(%IsStrong({
+  assertStrongObject({
     x001: 0, x002: 0, x003: 0, x004: 0, x005: 0,
     x006: 0, x007: 0, x008: 0, x009: 0, x010: 0,
     x011: 0, x012: 0, x013: 0, x014: 0, x015: 0,
     x016: 0, x017: 0, x018: 0, x019: 0, x020: 0,
     x021: 0, x022: 0, x023: 0, x024: 0, x025: 0,
     x026: 0, x027: 0, x028: 0, x029: 0, x030: 0,
     x031: 0, x032: 0, x033: 0, x034: 0, x035: 0,
     x036: 0, x037: 0, x038: 0, x039: 0, x040: 0,
     x041: 0, x042: 0, x043: 0, x044: 0, x045: 0,
     x046: 0, x047: 0, x048: 0, x049: 0, x050: 0,
@@ skipping 20 matching lines @@
     x151: 0, x152: 0, x153: 0, x154: 0, x155: 0,
     x156: 0, x157: 0, x158: 0, x159: 0, x160: 0,
     x161: 0, x162: 0, x163: 0, x164: 0, x165: 0,
     x166: 0, x167: 0, x168: 0, x169: 0, x170: 0,
     x171: 0, x172: 0, x173: 0, x174: 0, x175: 0,
     x176: 0, x177: 0, x178: 0, x179: 0, x180: 0,
     x181: 0, x182: 0, x183: 0, x184: 0, x185: 0,
     x186: 0, x187: 0, x188: 0, x189: 0, x190: 0,
     x191: 0, x192: 0, x193: 0, x194: 0, x195: 0,
     x196: 0, x197: 0, x198: 0, x199: 0, x200: 0,
-  }));
-  assertTrue(%IsStrong({__proto__: {}, get a() {}, set b(x) {}}));
-  assertTrue(%IsStrong({[Date() + ""]: 0, [Symbol()]: 0}));
-  assertTrue(%IsStrong({m() { super.m() }}));
+  });
+  assertStrongObject({[Date() + ""]: 0, [Symbol()]: 0});
+  assertStrongObject({m() { super.m() }});
   // Object literals with constant functions are treated specially,
   // but currently only on the toplevel (using Realm.eval to emulate that).
-  assertTrue(%IsStrong({f: function(){}}));
-  assertTrue(%IsStrong(Realm.eval(Realm.current(),
-                       "'use strong'; ({f: function(){}})")));
+  assertStrongObject({f: function(){}});
+  assertStrongObject(Realm.eval(Realm.current(),
+                       "'use strong'; ({f: function(){}})"));
+  assertTrue(%IsStrong({__proto__: {}, get a() {}, set b(x) {}}));
 })();
 
 (function WeakArrayLiterals(...args) {
   let [...r] = [];
   assertTrue(!%IsStrong(args));
   assertTrue(!%IsStrong(r));
   assertTrue(!%IsStrong([]));
   assertTrue(!%IsStrong([1, 2, 3]));
   assertTrue(!%IsStrong([[[]]]));
   assertTrue(!%IsStrong([[1], {}, [[3]]]));
   assertTrue(!%IsStrong([[1], {}, [[3]]][0]));
   assertTrue(!%IsStrong([[1], {}, [[3]]][1]));
   assertTrue(!%IsStrong([[1], {}, [[3]]][2]));
   assertTrue(!%IsStrong([[1], {}, [[3]]][2][0]));
 })();
 
 (function StrongArrayLiterals(...args) {
   'use strong';
   let [...r] = [];
   // TODO(rossberg): teach strongness to FastCloneShallowArrayStub
   // assertTrue(%IsStrong(args));
   // assertTrue(%IsStrong(r));
   // assertTrue(%IsStrong([]));
   // assertTrue(%IsStrong([1, 2, 3]));
   // assertTrue(%IsStrong([1, 2, ...[3, 4], 5]));
-  assertTrue(%IsStrong([[[]]]));
-  assertTrue(%IsStrong([[1], {}, [[3]]]));
-  assertTrue(%IsStrong([[1], {}, [[3]]][0]));
-  assertTrue(%IsStrong([[1], {}, [[3]]][1]));
-  assertTrue(%IsStrong([[1], {}, [[3]]][2]));
-  assertTrue(%IsStrong([[1], {}, [[3]]][2][0]));
+  assertStrongArray([[[]]]);
+  assertStrongArray([[1], {}, [[3]]]);
+  assertStrongArray([[1], {}, [[3]]][0]);
+  assertStrongObject([[1], {}, [[3]]][1]);
+  assertStrongArray([[1], {}, [[3]]][2]);
+  assertStrongArray([[1], {}, [[3]]][2][0]);
 })();
 
 (function WeakFunctionLiterals() {
   function f() {}
   assertTrue(!%IsStrong(f));
   assertTrue(!%IsStrong(function(){}));
   assertTrue(!%IsStrong(function f(){}));
   assertTrue(!%IsStrong(() => {}));
   assertTrue(!%IsStrong(x => x));
   assertTrue(!%IsStrong({m(){}}.m));
   assertTrue(!%IsStrong(Object.getOwnPropertyDescriptor(
       {get a(){}}, 'a').get));
   assertTrue(!%IsStrong(Object.getOwnPropertyDescriptor(
       {set a(x){}}, 'a').set));
   assertTrue(!%IsStrong((class {static m(){}}).m));
   assertTrue(!%IsStrong(Object.getOwnPropertyDescriptor(
       class {static get a(){}}, 'a').get));
   assertTrue(!%IsStrong(Object.getOwnPropertyDescriptor(
       class {static set a(x){}}, 'a').set));
   assertTrue(!%IsStrong((new class {m(){}}).m));
   assertTrue(!%IsStrong(Object.getOwnPropertyDescriptor(
       (class {get a(){}}).prototype, 'a').get));
   assertTrue(!%IsStrong(Object.getOwnPropertyDescriptor(
       (class {set a(x){}}).prototype, 'a').set));
 })();
 
 (function StrongFunctionLiterals() {
   'use strong';
   function f() {}
-  assertTrue(%IsStrong(f));
-  assertTrue(%IsStrong(function(){}));
-  assertTrue(%IsStrong(function f(){}));
-  assertTrue(%IsStrong(() => {}));
-  assertTrue(%IsStrong(x => x));
-  assertTrue(%IsStrong({m(){}}.m));
-  assertTrue(%IsStrong(Object.getOwnPropertyDescriptor(
-      {get a(){}}, 'a').get));
-  assertTrue(%IsStrong(Object.getOwnPropertyDescriptor(
-      {set a(x){}}, 'a').set));
-  assertTrue(%IsStrong((class {static m(){}}).m));
-  assertTrue(%IsStrong(Object.getOwnPropertyDescriptor(
-      class {static get a(){}}, 'a').get));
-  assertTrue(%IsStrong(Object.getOwnPropertyDescriptor(
-      class {static set a(x){}}, 'a').set));
-  assertTrue(%IsStrong((new class {m(){}}).m));
-  assertTrue(%IsStrong(Object.getOwnPropertyDescriptor(
-      (class {get a(){}}).prototype, 'a').get));
-  assertTrue(%IsStrong(Object.getOwnPropertyDescriptor(
-      (class {set a(x){}}).prototype, 'a').set));
+  assertStrongFunction(f);
+  assertStrongFunction(function(){});
+  assertStrongFunction(function f(){});
+  assertStrongFunction(() => {});
+  assertStrongFunction(x => x);
+  assertStrongFunction({m(){}}.m);
+  assertStrongFunction(Object.getOwnPropertyDescriptor(
+      {get a(){}}, 'a').get);
+  assertStrongFunction(Object.getOwnPropertyDescriptor(
+      {set a(x){}}, 'a').set);
+  assertStrongFunction((class {static m(){}}).m);
+  assertStrongFunction(Object.getOwnPropertyDescriptor(
+      class {static get a(){}}, 'a').get);
+  assertStrongFunction(Object.getOwnPropertyDescriptor(
+      class {static set a(x){}}, 'a').set);
+  assertStrongFunction((new class {m(){}}).m);
+  assertStrongFunction(Object.getOwnPropertyDescriptor(
+      (class {get a(){}}).prototype, 'a').get);
+  assertStrongFunction(Object.getOwnPropertyDescriptor(
+      (class {set a(x){}}).prototype, 'a').set);
 })();
 
 (function SelfStrongFunctionLiterals() {
   function f() {'use strong'}
-  assertTrue(%IsStrong(f));
-  assertTrue(%IsStrong(function(){'use strong'}));
-  assertTrue(%IsStrong(function f(){'use strong'}));
-  assertTrue(%IsStrong(() => {'use strong'}));
-  assertTrue(%IsStrong(x => {'use strong'}));
-  assertTrue(%IsStrong({m(){'use strong'}}.m));
-  assertTrue(%IsStrong(Object.getOwnPropertyDescriptor(
-      {get a(){'use strong'}}, 'a').get));
-  assertTrue(%IsStrong(Object.getOwnPropertyDescriptor(
-      {set a(x){'use strong'}}, 'a').set));
-  assertTrue(%IsStrong((class {static m(){'use strong'}}).m));
-  assertTrue(%IsStrong(Object.getOwnPropertyDescriptor(
-      class {static get a(){'use strong'}}, 'a').get));
-  assertTrue(%IsStrong(Object.getOwnPropertyDescriptor(
-      class {static set a(x){'use strong'}}, 'a').set));
-  assertTrue(%IsStrong((new class {m(){'use strong'}}).m));
-  assertTrue(%IsStrong(Object.getOwnPropertyDescriptor(
-      (class {get a(){'use strong'}}).prototype, 'a').get));
-  assertTrue(%IsStrong(Object.getOwnPropertyDescriptor(
-      (class {set a(x){'use strong'}}).prototype, 'a').set));
+  assertStrongFunction(f);
+  assertStrongFunction(function(){'use strong'});
+  assertStrongFunction(function f(){'use strong'});
+  assertStrongFunction(() => {'use strong'});
+  assertStrongFunction(x => {'use strong'});
+  assertStrongFunction({m(){'use strong'}}.m);
+  assertStrongFunction(Object.getOwnPropertyDescriptor(
+      {get a(){'use strong'}}, 'a').get);
+  assertStrongFunction(Object.getOwnPropertyDescriptor(
+      {set a(x){'use strong'}}, 'a').set);
+  assertStrongFunction((class {static m(){'use strong'}}).m);
+  assertStrongFunction(Object.getOwnPropertyDescriptor(
+      class {static get a(){'use strong'}}, 'a').get);
+  assertStrongFunction(Object.getOwnPropertyDescriptor(
+      class {static set a(x){'use strong'}}, 'a').set);
+  assertStrongFunction((new class {m(){'use strong'}}).m);
+  assertStrongFunction(Object.getOwnPropertyDescriptor(
+      (class {get a(){'use strong'}}).prototype, 'a').get);
+  assertStrongFunction(Object.getOwnPropertyDescriptor(
+      (class {set a(x){'use strong'}}).prototype, 'a').set);
 })();
 
 (function WeakGeneratorLiterals() {
   function* g() {}
   assertTrue(!%IsStrong(g));
   assertTrue(!%IsStrong(function*(){}));
   assertTrue(!%IsStrong(function* g(){}));
   assertTrue(!%IsStrong({*m(){}}.m));
   assertTrue(!%IsStrong((class {static *m(){}}).m));
   assertTrue(!%IsStrong((new class {*m(){}}).m));
 })();
 
 (function StrongGeneratorLiterals() {
   'use strong';
   function* g() {}
-  assertTrue(%IsStrong(g));
-  assertTrue(%IsStrong(function*(){}));
-  assertTrue(%IsStrong(function* g(){}));
-  assertTrue(%IsStrong({*m(){}}.m));
-  assertTrue(%IsStrong((class {static *m(){}}).m));
-  assertTrue(%IsStrong((new class {*m(){}}).m));
+  assertStrongGenerator(g);
+  assertStrongGenerator(function*(){});
+  assertStrongGenerator(function* g(){});
+  assertStrongGenerator({*m(){}}.m);
+  assertStrongGenerator((class {static *m(){}}).m);
+  assertStrongGenerator((new class {*m(){}}).m);
 })();
 
 (function SelfStrongGeneratorLiterals() {
   function* g() {'use strong'}
-  assertTrue(%IsStrong(g));
-  assertTrue(%IsStrong(function*(){'use strong'}));
-  assertTrue(%IsStrong(function* g(){'use strong'}));
-  assertTrue(%IsStrong({*m(){'use strong'}}.m));
-  assertTrue(%IsStrong((class {static *m(){'use strong'}}).m));
-  assertTrue(%IsStrong((new class {*m(){'use strong'}}).m));
+  assertStrongGenerator(g);
+  assertStrongGenerator(function*(){'use strong'});
+  assertStrongGenerator(function* g(){'use strong'});
+  assertStrongGenerator({*m(){'use strong'}}.m);
+  assertStrongGenerator((class {static *m(){'use strong'}}).m);
+  assertStrongGenerator((new class {*m(){'use strong'}}).m);
 })();
 
 (function WeakClassLiterals() {
   function assertWeakClass(C) {
     assertTrue(!%IsStrong(C));
     assertTrue(!%IsStrong(C.prototype));
   }
   class C {};
   class D extends C {};
   class E extends Object {};
@@ skipping 53 matching lines @@
 
 (function WeakRegExpLiterals() {
   assertTrue(!%IsStrong(/abc/));
 })();
 
 (function StrongRegExpLiterals() {
   'use strong';
   // TODO(rossberg): implement strong regexp literals
   // assertTrue(%IsStrong(/abc/));
 })();