Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1158933002: [strong] fix strong array, object prototypes (Closed)

Created:
5 years, 7 months ago by conradw
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] fix strong array, object prototypes Strong Object/Array literals are currently being created with incorrect internal prototypes. This CL fixes this and extends the test suite to check. BUG= LOG=N Committed: https://crrev.com/092acb2b9629c894efb69f6e78bd2439db197aab Cr-Commit-Position: refs/heads/master@{#28655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -77 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/strong/literals.js View 6 chunks +96 lines, -74 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
conradw
PTAL
5 years, 7 months ago (2015-05-27 13:34:44 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 7 months ago (2015-05-27 13:49:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158933002/1
5 years, 7 months ago (2015-05-27 13:53:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 13:55:08 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 13:55:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/092acb2b9629c894efb69f6e78bd2439db197aab
Cr-Commit-Position: refs/heads/master@{#28655}

Powered by Google App Engine
This is Rietveld 408576698