Issue 115893005: Improve adb_run_mojo_shell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115893005: Improve adb_run_mojo_shell (Closed)

Created:
7 years ago by DaveMoore

Modified:
7 years ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, craigdh+watch_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, ben+mojo_chromium.org, darin (slow to review), frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Improve adb_run_mojo_shell BUG=None R=abarth@chromium.org, abarth Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240921

Patch Set 1 #

Total comments: 1

Patch Set 2 : text mess up #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	build/android/adb_run_mojo_shell	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

DaveMoore

I found this a better way of running the shell. It kills any existing instances ...

7 years ago (2013-12-15 21:48:12 UTC) #1

abarth-chromium

https://codereview.chromium.org/115893005/diff/1/build/android/adb_run_mojo_shell File build/android/adb_run_mojo_shell (right): https://codereview.chromium.org/115893005/diff/1/build/android/adb_run_mojo_shell#newcode16 build/android/adb_run_mojo_shell:16: adb logcat -s MojoShellApplication MojoShellActivity chromiumdavemoore@davemoorez:/work/chrome/src$ ^C Is there ...

7 years ago (2013-12-15 22:22:23 UTC) #2

DaveMoore

7 years ago (2013-12-16 18:01:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r240921 (presubmit successful).

Expand Messages | Collapse Messages