Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1158913002: Replacing the 'return 0;' statements with 'return nullptr;' (Closed)

Created:
5 years, 7 months ago by tanay.c
Modified:
5 years, 6 months ago
Reviewers:
Habib Virji, pdr.
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replacing the 'return 0;' statements with 'return nullptr;' BUG=492312 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196086

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -75 lines) Patch
M public/platform/Platform.h View 1 17 chunks +47 lines, -47 lines 0 comments Download
M public/platform/WebCompositorSupport.h View 1 chunk +18 lines, -18 lines 0 comments Download
M public/platform/WebCrypto.h View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebGraphicsContext3D.h View 3 chunks +3 lines, -3 lines 0 comments Download
M public/platform/WebMediaPlayer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M public/platform/WebMediaStreamCenter.h View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebServiceWorker.h View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebServiceWorkerRegistration.h View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebUnitTestSupport.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
tanay.c
Please take a look
5 years, 7 months ago (2015-05-27 13:21:11 UTC) #2
tanay.c
PTAL Added myself to the authors list https://codereview.chromium.org/1162503004/
5 years, 6 months ago (2015-05-28 12:55:01 UTC) #4
pdr.
LGTM
5 years, 6 months ago (2015-05-28 20:07:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158913002/20001
5 years, 6 months ago (2015-05-28 20:07:50 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 22:27:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196086

Powered by Google App Engine
This is Rietveld 408576698