Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1158903002: [test] Add sanitizer coverage to gyp configs. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Add sanitizer coverage to gyp configs. BUG=chromium:489254 LOG=n Committed: https://crrev.com/a814516a08c7fba50be8a8100f985473972dffbc Cr-Commit-Position: refs/heads/master@{#28663}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -24 lines) Patch
M build/standalone.gypi View 1 4 chunks +57 lines, -24 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1158903002/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1158903002/diff/1/build/standalone.gypi#newcode399 build/standalone.gypi:399: ['OS=="mac"', { Refactoring: I'm nesting the conditions the ...
5 years, 7 months ago (2015-05-27 10:12:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158903002/1
5 years, 7 months ago (2015-05-27 10:13:00 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/6174)
5 years, 7 months ago (2015-05-27 10:17:05 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158903002/20001
5 years, 7 months ago (2015-05-27 10:19:49 UTC) #8
Michael Achenbach
Ignore patch 1.
5 years, 7 months ago (2015-05-27 10:19:54 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-27 10:45:00 UTC) #11
Michael Achenbach
+titzer This is basically c/p from: https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&l=4460
5 years, 7 months ago (2015-05-27 13:39:10 UTC) #13
earthdok
lgtm
5 years, 7 months ago (2015-05-27 15:13:22 UTC) #14
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-27 15:17:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158903002/20001
5 years, 7 months ago (2015-05-27 16:17:08 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-27 16:18:29 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 16:18:44 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a814516a08c7fba50be8a8100f985473972dffbc
Cr-Commit-Position: refs/heads/master@{#28663}

Powered by Google App Engine
This is Rietveld 408576698