Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1158883006: [turbofan] Ship TF for class literals. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ship TF for class literals. R=bmeurer@chromium.org BUG=v8:4158 LOG=N Committed: https://crrev.com/d71009a564f7bac8a8889cf66358ff6daeb4ae14 Cr-Commit-Position: refs/heads/master@{#28761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ast-numbering.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-02 10:14:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158883006/1
5 years, 6 months ago (2015-06-02 11:43:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 11:47:17 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d71009a564f7bac8a8889cf66358ff6daeb4ae14 Cr-Commit-Position: refs/heads/master@{#28761}
5 years, 6 months ago (2015-06-02 11:47:38 UTC) #5
arv (Not doing code reviews)
One problem is that we still deopt on all super.prop and super() access so in ...
5 years, 6 months ago (2015-06-02 13:03:46 UTC) #6
Michael Starzinger
5 years, 6 months ago (2015-06-02 13:15:13 UTC) #7
Message was sent while issue was closed.
On 2015/06/02 13:03:46, arv wrote:
> One problem is that we still deopt on all super.prop and super() access so in
> practice the functions created by the class literals will not use TF.
> 
> See https://codereview.chromium.org/1149133005/ for TF super.prop. It has some
> failures that I need to look into but I have some more pressing work to focus
on
> before getting back to it.

Please note that this is about functions "containing a class literal" not the
functions "making up a class literal".

Powered by Google App Engine
This is Rietveld 408576698