Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: runtime/vm/service/service.md

Issue 1158863002: Mark script kinds as private in the service protocol. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: sync Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/report_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service/service.md
diff --git a/runtime/vm/service/service.md b/runtime/vm/service/service.md
index 4fb2078f4b33b9be8e511e4f51c498e61d8bf37c..705205ef218010d7f6453e6ba2d81e2053e5c70c 100644
--- a/runtime/vm/service/service.md
+++ b/runtime/vm/service/service.md
@@ -1531,9 +1531,6 @@ A _SentinelType_ is used to distinguish different kinds of _Sentinel_ objects.
class @Script extends @Object {
// The uri from which this script was loaded.
string uri;
-
- // What kind of script is this?
- string kind;
}
```
@@ -1544,9 +1541,6 @@ class Script extends Object {
// The uri from which this script was loaded.
string uri;
- // What kind of script is this?
- ScriptKind kind;
-
// The library which owns this script.
@Library library;
@@ -1578,21 +1572,6 @@ tokenPos | line | column
101 | 1 | 8
102 | 2 | 7
-### ScriptKind
-
-```
-enum ScriptKind {
- script,
- library,
- source,
- patch
-}
-```
-
-A _ScriptKind_ is used to classify a _Script_.
-
-TODO: We need to explain what this is about or find a way to hide it.
-
### Stack
```
« no previous file with comments | « runtime/vm/report_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698