Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Unified Diff: runtime/vm/report_test.cc

Issue 1158863002: Mark script kinds as private in the service protocol. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: sync Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/report_test.cc
diff --git a/runtime/vm/report_test.cc b/runtime/vm/report_test.cc
index 5e41af6a0362394e47174035bf231408ba8cc347..4d99e01f5c7ce1ac0a49417820a45881e9ac0195 100644
--- a/runtime/vm/report_test.cc
+++ b/runtime/vm/report_test.cc
@@ -32,7 +32,7 @@ TEST_CASE(TraceJSWarning) {
"\"script\":{\"type\":\"@Script\",\"fixedId\":true,"
"\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
"\"uri\":\"Plug\","
- "\"kind\":\"script\"},\"tokenPos\":0,"
+ "\"_kind\":\"script\"},\"tokenPos\":0,"
"\"message\":{\"type\":\"@String\"",
js.ToCString());
// Skip private _OneByteString.
@@ -50,7 +50,7 @@ TEST_CASE(TraceJSWarning) {
"\"@Script\",\"fixedId\":true,"
"\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
"\"uri\":\"Plug\","
- "\"kind\":\"script\"},\"tokenPos\":0,"
+ "\"_kind\":\"script\"},\"tokenPos\":0,"
"\"message\":{\"type\":\"@String\"",
trace_buffer->At(0)->message);
// Skip private _OneByteString.
@@ -61,7 +61,7 @@ TEST_CASE(TraceJSWarning) {
"\"@Script\",\"fixedId\":true,"
"\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
"\"uri\":\"Plug\","
- "\"kind\":\"script\"},\"tokenPos\":1,"
+ "\"_kind\":\"script\"},\"tokenPos\":1,"
"\"message\":{\"type\":\"@String\"",
trace_buffer->At(1)->message);
// Skip private _OneByteString.
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698