Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: sky/engine/core/painting/Point.h

Issue 1158843002: Sky: Add a Point class. (Closed) Base URL: git@github.com:/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/painting/Point.h
diff --git a/sky/engine/core/painting/Rect.h b/sky/engine/core/painting/Point.h
similarity index 53%
copy from sky/engine/core/painting/Rect.h
copy to sky/engine/core/painting/Point.h
index 5eedb013643e82d7f395a4cf8995ba96a7b04738..20e9fde02b514c4ad1e3d547551f70ff9de32b6a 100644
--- a/sky/engine/core/painting/Rect.h
+++ b/sky/engine/core/painting/Point.h
@@ -2,28 +2,28 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef SKY_ENGINE_CORE_PAINTING_RECT_H_
-#define SKY_ENGINE_CORE_PAINTING_RECT_H_
+#ifndef SKY_ENGINE_CORE_PAINTING_POINT_H_
+#define SKY_ENGINE_CORE_PAINTING_POINT_H_
#include "dart/runtime/include/dart_api.h"
#include "sky/engine/tonic/dart_converter.h"
-#include "third_party/skia/include/core/SkRect.h"
+#include "third_party/skia/include/core/SkPoint.h"
namespace blink {
-// Very simple wrapper for SkRect to add a null state.
-class Rect {
+// Very simple wrapper for SkPoint to add a null state.
+class Point {
public:
- SkRect sk_rect;
- bool is_null;
+ SkPoint skPoint;
+ bool isNull;
eseidel 2015/05/26 22:21:11 Why this style change? Is this Chromium style? (I
Matt Perry 2015/05/26 22:24:08 Oh - the old code is Chromium style. I saw Blink s
Matt Perry 2015/05/27 17:55:43 OK, so I'll keep the .cpp/.h filenames because tha
};
template<>
-struct DartConverter<Rect, void> {
- static Rect FromArgumentsWithNullCheck(Dart_NativeArguments args,
+struct DartConverter<Point, void> {
+ static Point FromArgumentsWithNullCheck(Dart_NativeArguments args,
int index,
Dart_Handle& exception);
};
} // namespace blink
-#endif // SKY_ENGINE_CORE_PAINTING_RECT_H_
+#endif // SKY_ENGINE_CORE_PAINTING_POINT_H_

Powered by Google App Engine
This is Rietveld 408576698