HttpServerProperties - Don't persist if SetServerNetworkStats is called

net/http/http_server_properties_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_server_properties_manager.h"
 
 #include "base/basictypes.h"
 #include "base/json/json_writer.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_registry_simple.h"
@@ skipping 507 matching lines @@
 
 TEST_F(HttpServerPropertiesManagerTest, ServerNetworkStats) {
   ExpectPrefsUpdate();
 
   HostPortPair mail_server("mail.google.com", 80);
   const ServerNetworkStats* stats =
       http_server_props_manager_->GetServerNetworkStats(mail_server);
   EXPECT_EQ(NULL, stats);
   ServerNetworkStats stats1;
   stats1.srtt = base::TimeDelta::FromMicroseconds(10);
-  http_server_props_manager_->SetServerNetworkStats(mail_server, stats1);
+  EXPECT_TRUE(
+      http_server_props_manager_->SetServerNetworkStats(mail_server, stats1));
+  // ExpectPrefsUpdate() should be called only once.
+  EXPECT_FALSE(
+      http_server_props_manager_->SetServerNetworkStats(mail_server, stats1));
 
   // Run the task.
   base::RunLoop().RunUntilIdle();
   Mock::VerifyAndClearExpectations(http_server_props_manager_.get());
 
   const ServerNetworkStats* stats2 =
       http_server_props_manager_->GetServerNetworkStats(mail_server);
   EXPECT_EQ(10, stats2->srtt.ToInternalValue());
 }
 
 TEST_F(HttpServerPropertiesManagerTest, Clear) {
   ExpectPrefsUpdate();
 
   HostPortPair spdy_server_mail("mail.google.com", 443);
   http_server_props_manager_->SetSupportsSpdy(spdy_server_mail, true);
   AlternativeService alternative_service(NPN_SPDY_4, "mail.google.com", 443);
   EXPECT_TRUE(http_server_props_manager_->SetAlternativeService(
       spdy_server_mail, alternative_service, 1.0));
   // ExpectPrefsUpdate() should be called only once.
   EXPECT_FALSE(http_server_props_manager_->SetAlternativeService(
       spdy_server_mail, alternative_service, 1.0));
   IPAddressNumber actual_address;
   CHECK(ParseIPLiteralToNumber("127.0.0.1", &actual_address));
   http_server_props_manager_->SetSupportsQuic(true, actual_address);
   ServerNetworkStats stats;
   stats.srtt = base::TimeDelta::FromMicroseconds(10);
-  http_server_props_manager_->SetServerNetworkStats(spdy_server_mail, stats);
+  EXPECT_TRUE(http_server_props_manager_->SetServerNetworkStats(
+      spdy_server_mail, stats));
+  EXPECT_FALSE(http_server_props_manager_->SetServerNetworkStats(
+      spdy_server_mail, stats));
 
   const SpdySettingsIds id1 = SETTINGS_UPLOAD_BANDWIDTH;
   const SpdySettingsFlags flags1 = SETTINGS_FLAG_PLEASE_PERSIST;
   const uint32 value1 = 31337;
   http_server_props_manager_->SetSpdySetting(
       spdy_server_mail, id1, flags1, value1);
 
   // Run the task.
   base::RunLoop().RunUntilIdle();
 
@@ skipping 116 matching lines @@
   EXPECT_FALSE(http_server_props_manager_->SetAlternativeService(
       server_www, www_altsvc, 1.0));
   EXPECT_TRUE(http_server_props_manager_->SetAlternativeService(
       server_mail, mail_altsvc, 0.2));
   EXPECT_FALSE(http_server_props_manager_->SetAlternativeService(
       server_mail, mail_altsvc, 0.2));
 
   // Set ServerNetworkStats.
   ServerNetworkStats stats;
   stats.srtt = base::TimeDelta::FromInternalValue(42);
-  http_server_props_manager_->SetServerNetworkStats(server_mail, stats);
+  EXPECT_TRUE(
+      http_server_props_manager_->SetServerNetworkStats(server_mail, stats));
 
   // Set SupportsQuic.
   IPAddressNumber actual_address;
   CHECK(ParseIPLiteralToNumber("127.0.0.1", &actual_address));
   http_server_props_manager_->SetSupportsQuic(true, actual_address);
 
   // Update cache.
   ExpectPrefsUpdate();
   ExpectCacheUpdate();
   http_server_props_manager_->ScheduleUpdateCacheOnPrefThread();
@@ skipping 87 matching lines @@
   // Run the task after shutdown, but before deletion.
   base::RunLoop().RunUntilIdle();
   Mock::VerifyAndClearExpectations(http_server_props_manager_.get());
   http_server_props_manager_.reset();
   base::RunLoop().RunUntilIdle();
 }
 
 }  // namespace
 
 }  // namespace net