Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1158823005: HttpServerProperties - Don't persist if SetServerNetworkStats is called (Closed)

Created:
5 years, 7 months ago by ramant (doing other things)
Modified:
5 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@update_http_props
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HttpServerProperties - Don't persist if SetServerNetworkStats is called with the same origin (HostPortPair) and value (ServerNetworkStats). This change reduces the number of times SetServerNetworkStats tries to persist HttpServerProperties to disk (currently 17% of persist calls are due to SetServerNetworkStats). BUG=451256 R=rch@chromium.org Committed: https://crrev.com/cce34d58dbec10d9d499e6b54e4a15d9fa66fcba Cr-Commit-Position: refs/heads/master@{#333173}

Patch Set 1 #

Patch Set 2 : Always update memory cache #

Total comments: 2

Patch Set 3 : Call updateprefs only if values change #

Patch Set 4 : Fix ASAN build #

Patch Set 5 : Rebase and fix valgrind error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M net/http/http_server_properties.h View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 1 2 3 4 1 chunk +9 lines, -1 line 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
ramant (doing other things)
5 years, 7 months ago (2015-05-28 01:42:24 UTC) #1
ramant (doing other things)
https://codereview.chromium.org/1158823005/diff/40001/net/http/http_server_properties_impl.cc File net/http/http_server_properties_impl.cc (right): https://codereview.chromium.org/1158823005/diff/40001/net/http/http_server_properties_impl.cc#newcode497 net/http/http_server_properties_impl.cc:497: return !old_stats || *old_stats != stats; Hi Ryan, Made ...
5 years, 6 months ago (2015-05-28 22:33:38 UTC) #3
ramant (doing other things)
https://codereview.chromium.org/1158823005/diff/40001/net/http/http_server_properties_impl.cc File net/http/http_server_properties_impl.cc (right): https://codereview.chromium.org/1158823005/diff/40001/net/http/http_server_properties_impl.cc#newcode497 net/http/http_server_properties_impl.cc:497: return !old_stats || *old_stats != stats; On 2015/05/28 22:33:38, ...
5 years, 6 months ago (2015-06-03 21:37:00 UTC) #4
Ryan Hamilton
lgtm
5 years, 6 months ago (2015-06-03 23:43:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158823005/60001
5 years, 6 months ago (2015-06-04 01:04:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/13836)
5 years, 6 months ago (2015-06-04 02:54:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158823005/120001
5 years, 6 months ago (2015-06-05 18:48:06 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/14617)
5 years, 6 months ago (2015-06-05 20:10:43 UTC) #16
ramant (doing other things)
Hi Ryan, After you had LGTM'ed the change, made a change to fix ASAN error ...
5 years, 6 months ago (2015-06-05 22:40:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158823005/140001
5 years, 6 months ago (2015-06-05 23:10:24 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:140001)
5 years, 6 months ago (2015-06-05 23:36:45 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 23:37:38 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/cce34d58dbec10d9d499e6b54e4a15d9fa66fcba
Cr-Commit-Position: refs/heads/master@{#333173}

Powered by Google App Engine
This is Rietveld 408576698