Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: sky/examples/stocks2/lib/stock_app.dart

Issue 1158813004: Style guide says enum values should be lowerCamelCase. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/examples/raw/render_paragraph.dart ('k') | sky/examples/stocks2/lib/stock_arrow.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/stocks2/lib/stock_app.dart
diff --git a/sky/examples/stocks2/lib/stock_app.dart b/sky/examples/stocks2/lib/stock_app.dart
index 1150e03f44646fae1b97281aca24145e3f22f2e3..f69f7e6db726f7686d18eb86a66003e57d4bae70 100644
--- a/sky/examples/stocks2/lib/stock_app.dart
+++ b/sky/examples/stocks2/lib/stock_app.dart
@@ -26,7 +26,7 @@ import 'package:sky/framework/rendering/box.dart';
import 'dart:async';
import 'dart:sky' as sky;
-enum StockMode { Optimistic, Pessimistic }
+enum StockMode { optimistic, pessimistic }
class StocksApp extends App {
@@ -106,7 +106,7 @@ class StocksApp extends App {
});
}
- StockMode _stockMode = StockMode.Optimistic;
+ StockMode _stockMode = StockMode.optimistic;
void _handleStockModeChange(StockMode value) {
setState(() {
_stockMode = value;
@@ -133,18 +133,18 @@ class StocksApp extends App {
// new MenuItem(
// key: 'Optimistic Menu Item',
// icon: 'action/thumb_up',
- // onGestureTap: (event) => _handleStockModeChange(StockMode.Optimistic),
+ // onGestureTap: (event) => _handleStockModeChange(StockMode.optimistic),
// children: [
// new ParentDataNode(new Text('Optimistic'), _flex1),
- // new Radio(key: 'optimistic-radio', value: StockMode.Optimistic, groupValue: _stockMode, onChanged: _handleStockModeChange)
+ // new Radio(key: 'optimistic-radio', value: StockMode.optimistic, groupValue: _stockMode, onChanged: _handleStockModeChange)
// ]),
// new MenuItem(
// key: 'Pessimistic Menu Item',
// icon: 'action/thumb_down',
- // onGestureTap: (event) => _handleStockModeChange(StockMode.Pessimistic),
+ // onGestureTap: (event) => _handleStockModeChange(StockMode.pessimistic),
// children: [
// new ParentDataNode(new Text('Pessimistic'), _flex1),
- // new Radio(key: 'pessimistic-radio', value: StockMode.Pessimistic, groupValue: _stockMode, onChanged: _handleStockModeChange)
+ // new Radio(key: 'pessimistic-radio', value: StockMode.pessimistic, groupValue: _stockMode, onChanged: _handleStockModeChange)
// ]),
// new MenuDivider(key: 'div2'),
new MenuItem(
« no previous file with comments | « sky/examples/raw/render_paragraph.dart ('k') | sky/examples/stocks2/lib/stock_arrow.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698