Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5823)

Unified Diff: chrome/browser/permissions/permission_manager.cc

Issue 1158813002: Use RenderFrameHost for ::RequestPermission() and ::CancelPermission(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fixes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_manager.cc
diff --git a/chrome/browser/permissions/permission_manager.cc b/chrome/browser/permissions/permission_manager.cc
index 7df26f0717eb2f44f7167dad45dad820da174d04..858f5b26e21387d0ca466ebeaeea26aa0bb81529 100644
--- a/chrome/browser/permissions/permission_manager.cc
+++ b/chrome/browser/permissions/permission_manager.cc
@@ -11,8 +11,8 @@
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "components/content_settings/core/common/permission_request_id.h"
#include "content/public/browser/permission_type.h"
+#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
-#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
using content::PermissionStatus;
@@ -97,7 +97,7 @@ PermissionManager::~PermissionManager() {
void PermissionManager::RequestPermission(
PermissionType permission,
- content::WebContents* web_contents,
+ content::RenderFrameHost* render_frame_host,
int request_id,
const GURL& requesting_origin,
bool user_gesture,
@@ -108,36 +108,38 @@ void PermissionManager::RequestPermission(
return;
}
- int render_process_id = web_contents->GetRenderProcessHost()->GetID();
- int render_view_id = web_contents->GetRenderViewHost()->GetRoutingID();
+ int render_process_id = render_frame_host->GetProcess()->GetID();
+ int render_frame_id = render_frame_host->GetRoutingID();
const PermissionRequestID request(render_process_id,
- render_view_id,
+ render_frame_id,
request_id,
requesting_origin);
- context->RequestPermission(web_contents, request, requesting_origin,
- user_gesture,
- base::Bind(&PermissionStatusCallbackWrapper,
- callback));
+ context->RequestPermission(
+ content::WebContents::FromRenderFrameHost(render_frame_host),
+ request, requesting_origin, user_gesture,
+ base::Bind(&PermissionStatusCallbackWrapper,
+ callback));
}
void PermissionManager::CancelPermissionRequest(
PermissionType permission,
- content::WebContents* web_contents,
+ content::RenderFrameHost* render_frame_host,
int request_id,
const GURL& requesting_origin) {
PermissionContextBase* context = PermissionContext::Get(profile_, permission);
if (!context)
return;
- int render_process_id = web_contents->GetRenderProcessHost()->GetID();
- int render_view_id = web_contents->GetRenderViewHost()->GetRoutingID();
+ int render_process_id = render_frame_host->GetProcess()->GetID();
+ int render_frame_id = render_frame_host->GetRoutingID();
const PermissionRequestID request(render_process_id,
- render_view_id,
+ render_frame_id,
request_id,
requesting_origin);
- context->CancelPermissionRequest(web_contents, request);
+ context->CancelPermissionRequest(
+ content::WebContents::FromRenderFrameHost(render_frame_host), request);
}
void PermissionManager::ResetPermission(PermissionType permission,
« no previous file with comments | « chrome/browser/permissions/permission_manager.h ('k') | chrome/browser/push_messaging/push_messaging_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698